2021-05-08 05:52 BST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002813Buildsystem[All Projects] Generalpublic2021-04-14 15:42
ReporterRyan Schmidt 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
Summary0002813: Makefile hardcodes perl; should use $(PERL)
DescriptionHello! Building NetSurf 3.10 on macOS I had a small problem because while netsurf/Makefile has a PERL variable and uses it in some places, in other places it hardcodes "perl".

I used the attached patch to fix the problem.

Looks like the code has been reorganized a bit since the 3.10 release.
Steps To ReproduceFor example run "make PERL=/some/other/perl" and notice that not all invocations of perl use that perl.
TagsNo tags attached.
Fixed in CI build #
Reported in CI build #
Attached Files
  • patch file icon perl.patch (1,565 bytes) 2021-04-14 15:42 -
    Use the specified perl.
    --- netsurf/Makefile.orig	2020-05-24 16:35:22.000000000 -0500
    +++ netsurf/Makefile	2021-04-13 21:34:45.000000000 -0500
    @@ -922,13 +922,13 @@
     
     # split fat messages into properties files suitable for uploading to transifex
     messages-split-tfx:
    -	for splitlang in $(FAT_LANGUAGES);do perl ./utils/split-messages.pl -l $${splitlang} -f transifex -p any -o Messages.any.$${splitlang}.tfx resources/FatMessages;done
    +	for splitlang in $(FAT_LANGUAGES);do $(SPLIT_MESSAGES) -l $${splitlang} -f transifex -p any -o Messages.any.$${splitlang}.tfx resources/FatMessages;done
     
     # download property files from transifex
     messages-fetch-tfx:
    -	for splitlang in $(FAT_LANGUAGES);do $(RM) Messages.any.$${splitlang}.tfx ; perl ./utils/fetch-transifex.pl -w insecure -l $${splitlang} -o Messages.any.$${splitlang}.tfx ;done
    +	for splitlang in $(FAT_LANGUAGES);do $(RM) Messages.any.$${splitlang}.tfx ; $(PERL) ./utils/fetch-transifex.pl -w insecure -l $${splitlang} -o Messages.any.$${splitlang}.tfx ;done
     
     # merge property files into fat messages
     messages-import-tfx: messages-fetch-tfx
    -	for tfxlang in $(FAT_LANGUAGES);do perl ./utils/import-messages.pl -l $${tfxlang} -p any -f transifex -o resources/FatMessages -i resources/FatMessages -I Messages.any.$${tfxlang}.tfx ; $(RM) Messages.any.$${tfxlang}.tfx; done
    +	for tfxlang in $(FAT_LANGUAGES);do $(PERL) ./utils/import-messages.pl -l $${tfxlang} -p any -f transifex -o resources/FatMessages -i resources/FatMessages -I Messages.any.$${tfxlang}.tfx ; $(RM) Messages.any.$${tfxlang}.tfx; done
     
    
    patch file icon perl.patch (1,565 bytes) 2021-04-14 15:42 +

-Relationships
+Relationships

-Notes
There are no notes attached to this issue.
+Notes

-Issue History
Date Modified Username Field Change
2021-04-14 15:42 Ryan Schmidt New Issue
2021-04-14 15:42 Ryan Schmidt File Added: perl.patch
+Issue History