2020-07-13 04:13 BST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002780NetSurf[All Projects] Generalpublic2020-06-18 23:21
ReporterMichael Orlitzky 
Assigned To 
SeverityfeatureReproducibilityhave not tried 
StatusnewResolutionopen 
PlatformN/AOSOS Version
Product Version3.10 
Target VersionFixed in Version 
Summary0002780: Include image headers conditionally
DescriptionWe carry the attached patch on Gentoo to only include certain image headers when they will be needed (because otherwise they may not be present). If you think it makes sense to apply upstream, it's yours =)
TagsNo tags attached.
Fixed in CI build #
Reported in CI build #
URL of problem page
Attached Files
  • patch file icon netsurf-3.9-conditionally-include-image-headers.patch (775 bytes) 2020-06-18 23:21 -
    diff -rup a/content/handlers/image/image.c b/content/handlers/image/image.c
    --- a/content/handlers/image/image.c	2019-07-17 10:28:13.000000000 +0000
    +++ b/content/handlers/image/image.c	2019-09-27 15:09:03.860000000 +0000
    @@ -27,15 +27,31 @@
     #include "netsurf/content.h"
     #include "desktop/gui_internal.h"
    
    +#ifdef WITH_BMP
     #include "image/bmp.h"
    +#endif
    +#ifdef WITH_GIF
     #include "image/gif.h"
    +#endif
     #include "image/ico.h"
    +#ifdef WITH_JPEG
     #include "image/jpeg.h"
    +#endif
    +#ifdef WITH_NSSPRITE
     #include "image/nssprite.h"
    +#endif
    +#ifdef WITH_PNG
     #include "image/png.h"
    +#endif
    +#ifdef WITH_RSVG
     #include "image/rsvg.h"
    +#endif
    +#ifdef WITH_NS_SVG
     #include "image/svg.h"
    +#endif
    +#ifdef WITH_WEBP
     #include "image/webp.h"
    +#endif
     #include "image/image.h"
    
     /**
    

-Relationships
+Relationships

-Notes
There are no notes attached to this issue.
+Notes

-Issue History
Date Modified Username Field Change
2020-06-18 23:21 Michael Orlitzky New Issue
2020-06-18 23:21 Michael Orlitzky File Added: netsurf-3.9-conditionally-include-image-headers.patch
+Issue History