MantisBT - NetSurf
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002780NetSurf[All Projects] Generalpublic2020-06-18 23:212020-09-18 08:11
ReporterMichael Orlitzky 
Assigned To 
PrioritynormalSeverityfeatureReproducibilityhave not tried
StatusclosedResolutionno change required 
PlatformN/AOSOS Version
Product Version3.10 
Target VersionFixed in Version 
Fixed in CI build #
Reported in CI build #
URL of problem page
Summary0002780: Include image headers conditionally
DescriptionWe carry the attached patch on Gentoo to only include certain image headers when they will be needed (because otherwise they may not be present). If you think it makes sense to apply upstream, it's yours =)
TagsNo tags attached.
Relationships
Attached Filespatch netsurf-3.9-conditionally-include-image-headers.patch (775) 2020-06-18 23:21
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=677&type=bug

Notes
(0002290)
Vincent Sanders   
2020-09-18 08:11   
Thank you for submitting this patch for consideration

Unfortunately there is no need for this patch.

The headers made conditional in the patch are *purely* internal interfaces which require no additional libraries to have included.

The *calls* to those functions and implementation are already conditional depending on the configured image libraries.

Issue History
Date ModifiedUsernameFieldChange
2020-06-18 23:21Michael OrlitzkyNew Issue
2020-06-18 23:21Michael OrlitzkyFile Added: netsurf-3.9-conditionally-include-image-headers.patch
2020-09-18 08:11Vincent SandersStatusnew => closed
2020-09-18 08:11Vincent SandersResolutionopen => no change required
2020-09-18 08:11Vincent SandersNote Added: 0002290