| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 0002542 | NetSurf | Development | public | 2017-05-14 09:01 | 2023-08-13 23:52 | ||||||||
| Reporter | Alastair Hughes | ||||||||||||
| Assigned To | |||||||||||||
| Severity | minor | Reproducibility | always | ||||||||||
| Status | confirmed | Resolution | reopened | ||||||||||
| Platform | x86_64 | OS | Linux | OS Version | Arch | ||||||||
| Product Version | 3.6 | ||||||||||||
| Target Version | Fixed in Version | ||||||||||||
| Summary | 0002542: Build failure against upstream's utf8proc due to moved header | ||||||||||||
| Description | Upstream (https://github.com/JuliaLang/utf8proc) installs utf8proc.h to include/utf8proc.h instead of include/libutfproc/utf8proc.h (https://github.com/JuliaLang/utf8proc/blob/master/Makefile#L91). However, netsurf assumes it will be in include/libutf8proc/utf8proc.h (http://source.netsurf-browser.org/netsurf.git/tree/utils/idna.c#n29). It would be nice if Netsurf could use the upstream version unaltered. | ||||||||||||
| Steps To Reproduce | Attempt to build netsurf against upstream utf8proc instead of netsurf's fork. | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Fixed in CI build # | |||||||||||||
| Reported in CI build # | |||||||||||||
| URL of problem page | |||||||||||||
| Attached Files |
| ||||||||||||
 Relationships |
|
 Relationships |
| Notes |
|
Vincent Sanders (administrator) 2017-06-09 19:38 |
The fixes were merged upstream https://github.com/JuliaLang/utf8proc/pull/88 and placed in release 2.1 https://julialang.org/utf8proc/releases/ as such netsurf can now be built with upstream |
Alastair Hughes (reporter) 2017-06-09 23:46 |
I'm using utf8proc 2.1, netsurf 3.6, and it does *not* build out of the box. To fix the build I have to provide a pkg-config file with the utf8proc package, and fix idna.c to include <utf8proc.h> instead of <libutf8proc/utf8proc.h>. This issue is about the utf8proc.h header location. I'm building netsurf on Arch Linux, with an updated version of the utf8proc package. If there's some flag I've missed which makes things work please share :D |
|
Vincent Sanders (administrator) 2017-06-10 07:52 |
you are correct although the code changes were made https://github.com/JuliaLang/utf8proc/issues/105 the pkg-config issue has not been resolved. we will attempt to persuade upstream to take notice of this issue at which point upstream header location will be resolved |
|
Michael Orlitzky (reporter) 2023-08-13 23:52 |
The pkg-config issue was resolved a long time ago: https://github.com/JuliaStrings/utf8proc/commit/5dcd38217a7d4351b6dbf18d1aa8aa21d7e5bec3 Fixing the header location now is trivial, but git grep says that docs/env.sh also needs an update to move utf8proc from an internal to an external dependency. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-05-14 09:01 | Alastair Hughes | New Issue | |
| 2017-06-09 19:38 | Vincent Sanders | Status | new => resolved |
| 2017-06-09 19:38 | Vincent Sanders | Note Added: 0001567 | |
| 2017-06-09 23:46 | Alastair Hughes | Status | resolved => feedback |
| 2017-06-09 23:46 | Alastair Hughes | Resolution | open => reopened |
| 2017-06-09 23:46 | Alastair Hughes | Note Added: 0001568 | |
| 2017-06-10 07:52 | Vincent Sanders | Status | feedback => confirmed |
| 2017-06-10 07:52 | Vincent Sanders | Note Added: 0001569 | |
| 2023-08-13 23:52 | Michael Orlitzky | Note Added: 0002422 | |
| Issue History |