MantisBT - NetSurf
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002542NetSurfDevelopmentpublic2017-05-14 09:012023-08-13 23:52
ReporterAlastair Hughes 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusconfirmedResolutionreopened 
Platformx86_64OSLinuxOS VersionArch
Product Version3.6 
Target VersionFixed in Version 
Fixed in CI build #
Reported in CI build #
URL of problem page
Summary0002542: Build failure against upstream's utf8proc due to moved header
DescriptionUpstream (https://github.com/JuliaLang/utf8proc) installs utf8proc.h to include/utf8proc.h instead of include/libutfproc/utf8proc.h (https://github.com/JuliaLang/utf8proc/blob/master/Makefile#L91). However, netsurf assumes it will be in include/libutf8proc/utf8proc.h (http://source.netsurf-browser.org/netsurf.git/tree/utils/idna.c#n29). It would be nice if Netsurf could use the upstream version unaltered.
Steps To ReproduceAttempt to build netsurf against upstream utf8proc instead of netsurf's fork.
TagsNo tags attached.
Relationships
Attached Files

Notes
(0001567)
Vincent Sanders   
2017-06-09 19:38   
The fixes were merged upstream

https://github.com/JuliaLang/utf8proc/pull/88

and placed in release 2.1

https://julialang.org/utf8proc/releases/

as such netsurf can now be built with upstream
(0001568)
Alastair Hughes   
2017-06-09 23:46   
I'm using utf8proc 2.1, netsurf 3.6, and it does *not* build out of the box.

To fix the build I have to provide a pkg-config file with the utf8proc package, and fix idna.c to include <utf8proc.h> instead of <libutf8proc/utf8proc.h>. This issue is about the utf8proc.h header location.

I'm building netsurf on Arch Linux, with an updated version of the utf8proc package. If there's some flag I've missed which makes things work please share :D
(0001569)
Vincent Sanders   
2017-06-10 07:52   
you are correct although the code changes were made

https://github.com/JuliaLang/utf8proc/issues/105

the pkg-config issue has not been resolved.

we will attempt to persuade upstream to take notice of this issue at which point upstream header location will be resolved
(0002422)
Michael Orlitzky   
2023-08-13 23:52   
The pkg-config issue was resolved a long time ago:

https://github.com/JuliaStrings/utf8proc/commit/5dcd38217a7d4351b6dbf18d1aa8aa21d7e5bec3

Fixing the header location now is trivial, but git grep says that docs/env.sh also needs an update to move utf8proc from an internal to an external dependency.

Issue History
Date ModifiedUsernameFieldChange
2017-05-14 09:01Alastair HughesNew Issue
2017-06-09 19:38Vincent SandersStatusnew => resolved
2017-06-09 19:38Vincent SandersNote Added: 0001567
2017-06-09 23:46Alastair HughesStatusresolved => feedback
2017-06-09 23:46Alastair HughesResolutionopen => reopened
2017-06-09 23:46Alastair HughesNote Added: 0001568
2017-06-10 07:52Vincent SandersStatusfeedback => confirmed
2017-06-10 07:52Vincent SandersNote Added: 0001569
2023-08-13 23:52Michael OrlitzkyNote Added: 0002422