View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0002227 | NetSurf | Core-specific | public | 2014-11-23 16:42 | 2016-02-16 13:51 | ||||
Reporter | Chris Young | ||||||||
Assigned To | Chris Young | ||||||||
Severity | minor | Reproducibility | always | ||||||
Status | closed | Resolution | fixed | ||||||
Platform | Amiga | OS | AmigaOS | OS Version | 4.1 | ||||
Product Version | 3.3 | ||||||||
Target Version | 3.4 | Fixed in Version | 3.4 | ||||||
Summary | 0002227: nsgif_animate runs when gif not displayed | ||||||||
Description | nsgif_animate starts running when an animated gif is displayed, but does not stop running when it is not displayed (or even when it is no longer in any browser_window). It only stops running when the object is destroyed. | ||||||||
Steps To Reproduce | Find a page with an animated GIF. Browse off of that page and keep browsing until it is destroyed. Some extra logging in nsgif_animate will be required to see when it is running/stops running. | ||||||||
Tags | No tags attached. | ||||||||
Fixed in CI build # | 3390 | ||||||||
Reported in CI build # | 2377 | ||||||||
URL of problem page | |||||||||
Attached Files |
|
Relationships | ||||||
|
Notes | |
Chris Young (developer) 2014-11-23 16:43 |
I think nsgif_animate should only continue to run if the GIF in question is being displayed, or at the very least exists in a currently displayed browser_window. At the moment there is some overhead from calling this function several times a second for each animated gif when it isn't relevant. |
Chris Young (developer) 2014-12-12 17:14 |
I've pushed a potential fix to chris/stop-gif-anim. Functionally it works but will need checking/merging. It also guards against the problem in related bug#2228 |
Chris Young (developer) 2015-10-28 11:57 |
Patch attached for just the GIF issue. |
Vincent Sanders (administrator) 2016-02-16 13:51 |
Confirmed fixed in 3.4 release |
Issue History | |||
Date Modified | Username | Field | Change |
---|---|---|---|
2014-11-23 16:42 | Chris Young | New Issue | |
2014-11-23 16:43 | Chris Young | Note Added: 0000540 | |
2014-12-01 14:17 | Vincent Sanders | Status | new => confirmed |
2014-12-09 15:21 | Chris Young | Relationship added | related to 0002228 |
2014-12-12 17:14 | Chris Young | Note Added: 0000556 | |
2015-10-28 11:57 | Chris Young | File Added: 1113ce117d5b860220bd979bd02dd067b8a9415e.patch | |
2015-10-28 11:57 | Chris Young | Assigned To | => Chris Young |
2015-10-28 11:57 | Chris Young | Status | confirmed => assigned |
2015-10-28 11:57 | Chris Young | Note Added: 0000981 | |
2015-10-28 11:57 | Chris Young | Status | assigned => confirmed |
2015-11-07 22:03 | Chris Young | Category | General => Core-specific |
2015-11-07 22:03 | Chris Young | Target Version | => 3.4 |
2015-11-07 22:03 | Chris Young | Description Updated | View Revisions |
2016-02-11 19:57 | Chris Young | Fixed in CI build # | => 3390 |
2016-02-11 19:57 | Chris Young | Status | confirmed => resolved |
2016-02-11 19:57 | Chris Young | Fixed in Version | => 3.4 |
2016-02-11 19:57 | Chris Young | Resolution | open => fixed |
2016-02-16 13:51 | Vincent Sanders | Note Added: 0001222 | |
2016-02-16 13:51 | Vincent Sanders | Status | resolved => closed |
2016-02-16 13:51 | Vincent Sanders | Description Updated | View Revisions |