MantisBT - NetSurf
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002227NetSurfCore-specificpublic2014-11-23 16:422016-02-16 13:51
ReporterChris Young 
Assigned ToChris Young 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformAmigaOSAmigaOSOS Version4.1
Product Version3.3 
Target Version3.4Fixed in Version3.4 
Fixed in CI build #3390
Reported in CI build #2377
URL of problem page
Summary0002227: nsgif_animate runs when gif not displayed
Descriptionnsgif_animate starts running when an animated gif is displayed, but does not stop running when it is not displayed (or even when it is no longer in any browser_window). It only stops running when the object is destroyed.
Steps To ReproduceFind a page with an animated GIF. Browse off of that page and keep browsing until it is destroyed. Some extra logging in nsgif_animate will be required to see when it is running/stops running.
TagsNo tags attached.
Relationships
related to 0002228acknowledged  Possible race condition with scheduler 
Attached Filespatch 1113ce117d5b860220bd979bd02dd067b8a9415e.patch (2,864) 2015-10-28 11:57
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=340&type=bug

Notes
(0000540)
Chris Young   
2014-11-23 16:43   
I think nsgif_animate should only continue to run if the GIF in question is being displayed, or at the very least exists in a currently displayed browser_window.
At the moment there is some overhead from calling this function several times a second for each animated gif when it isn't relevant.
(0000556)
Chris Young   
2014-12-12 17:14   
I've pushed a potential fix to chris/stop-gif-anim.
Functionally it works but will need checking/merging.
It also guards against the problem in related bug#2228
(0000981)
Chris Young   
2015-10-28 11:57   
Patch attached for just the GIF issue.
(0001222)
Vincent Sanders   
2016-02-16 13:51   
Confirmed fixed in 3.4 release

Issue History
Date ModifiedUsernameFieldChange
2014-11-23 16:42Chris YoungNew Issue
2014-11-23 16:43Chris YoungNote Added: 0000540
2014-12-01 14:17Vincent SandersStatusnew => confirmed
2014-12-09 15:21Chris YoungRelationship addedrelated to 0002228
2014-12-12 17:14Chris YoungNote Added: 0000556
2015-10-28 11:57Chris YoungFile Added: 1113ce117d5b860220bd979bd02dd067b8a9415e.patch
2015-10-28 11:57Chris YoungAssigned To => Chris Young
2015-10-28 11:57Chris YoungStatusconfirmed => assigned
2015-10-28 11:57Chris YoungNote Added: 0000981
2015-10-28 11:57Chris YoungStatusassigned => confirmed
2015-11-07 22:03Chris YoungCategoryGeneral => Core-specific
2015-11-07 22:03Chris YoungTarget Version => 3.4
2015-11-07 22:03Chris YoungDescription Updatedbug_revision_view_page.php?rev_id=1687#r1687
2016-02-11 19:57Chris YoungFixed in CI build # => 3390
2016-02-11 19:57Chris YoungStatusconfirmed => resolved
2016-02-11 19:57Chris YoungFixed in Version => 3.4
2016-02-11 19:57Chris YoungResolutionopen => fixed
2016-02-16 13:51Vincent SandersNote Added: 0001222
2016-02-16 13:51Vincent SandersStatusresolved => closed
2016-02-16 13:51Vincent SandersDescription Updatedbug_revision_view_page.php?rev_id=1801#r1801