| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002736 | libnslog | [All Projects] General | public | 2020-01-23 06:49 | 2020-05-27 08:12 | ||||
| Reporter | bavier | ||||||||
| Assigned To | kinnison | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | Linux | OS | Guix System | OS Version | guix 9448d0e | ||||
| Summary | 0002736: libnslog tests fail with latest check version 0.13 | ||||||||
| Description | Running tests from libnslog version 0.1.2 that were linked against most recent check version 0.13 produces the following failures: Running suite(s): Test suite for libnslog libnslog: Basic tests 70%: Checks: 24, Failures: 7, Errors: 0 test/basictests.c:86:F:Simple log checks, no filters:test_nslog_trivial_corked_message:0: Captured message wasn't correct function name test/basictests.c:112:F:Simple log checks, no filters:test_nslog_trivial_uncorked_message:0: Captured message wasn't correct function name test/basictests.c:153:F:Simple log checks, no filters:test_nslog_two_corked_messages:0: Captured message wasn't correct function name test/basictests.c:226:F:Simple filter checks:test_nslog_simple_filter_corked_message:0: Captured message wasn't correct function name test/basictests.c:253:F:Simple filter checks:test_nslog_simple_filter_uncorked_message:0: Captured message wasn't correct function name test/basictests.c:280:F:Simple filter checks:test_nslog_simple_filter_subcategory_message:0: Captured message wasn't correct function name test/basictests.c:534:F:Trivial, varied, filter checks:test_nslog_filter_funcname:0: Captured message count was wrong The failures in question attempt to check the function name logged by libnslog against the expected test case function name. In check 0.13 however, the implementation of the "START_TEST" macro was changed in such a way that the testcase functions have a "_fn" suffix. That is, the actual function name of the test should maybe be treated as an implementation detail. | ||||||||
| Steps To Reproduce | 1. Build libnslog against check version 0.13. 2. Run test_testrunner "basic" tests | ||||||||
| Additional Information | Workaround in GNU Guix package is currently to build with the older check 0.12 package: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7357b3d7a52eb5db1674012c50d308d792741c48 | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
kinnison (administrator) 2020-02-21 10:58 |
Thanks, I've fixed the test suites to cope with both variants of check by using the `__func__` macro appropriately instead. |
Vincent Sanders (administrator) 2020-05-27 08:12 |
Thankyou for reporting this issue. We believe this is fixed in the 3.10 release. If this is not the case please feel free to reopen the issue with additional details. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-01-23 06:49 | bavier | New Issue | |
| 2020-02-21 10:01 | kinnison | Project | NetSurf => libnslog |
| 2020-02-21 10:01 | kinnison | Category | Development => General |
| 2020-02-21 10:07 | kinnison | Assigned To | => kinnison |
| 2020-02-21 10:07 | kinnison | Status | new => assigned |
| 2020-02-21 10:58 | kinnison | Status | assigned => resolved |
| 2020-02-21 10:58 | kinnison | Resolution | open => fixed |
| 2020-02-21 10:58 | kinnison | Note Added: 0002170 | |
| 2020-05-27 08:12 | Vincent Sanders | Status | resolved => closed |
| 2020-05-27 08:12 | Vincent Sanders | Note Added: 0002225 | |
| Issue History |