| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002687 | NetSurf | Core-specific | public | 2019-08-02 14:52 | 2020-05-27 08:16 | ||||
| Reporter | Harriet Bazley | ||||||||
| Assigned To | Vincent Sanders | ||||||||
| Severity | crash | Reproducibility | always | ||||||
| Status | closed | Resolution | fixed | ||||||
| Platform | Iyonix | OS | RISC OS | OS Version | 5.22 | ||||
| Product Version | |||||||||
| Target Version | Fixed in Version | 3.10 | |||||||
| Summary | 0002687: Crash on complete save | ||||||||
| Description | When trying to carry out a complete save of the page https://www.miresparis.com/category/spots/hotelparticulier/, Netsurf crashes with a segfault. | ||||||||
| Steps To Reproduce | Visit URL, and Adjust-click on Save icon. I shut down and rebooted the computer, but it made no difference. | ||||||||
| Additional Information | The shell application created during the attempted save contains the stylesheets but no HTML or images. Javascript disabled. | ||||||||
| Tags | No tags attached. | ||||||||
| Fixed in CI build # | 4875 | ||||||||
| Reported in CI build # | 4760 | ||||||||
| URL of problem page | https://www.miresparis.com/category/spots/hotelparticulier/ | ||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
Vincent Sanders (administrator) 2019-10-21 09:54 |
overrunning buffers in save_complete_rewrite_stylesheet_urls() regex calls ==28508== 24 errors in context 7 of 116: ==28508== Invalid read of size 1 ==28508== at 0x4838C74: strlen (vg_replace_strmem.c:460) ==28508== by 0x6488633: regexec@@GLIBC_2.3.4 (regexec.c:210) ==28508== by 0x354B01: save_complete_rewrite_stylesheet_urls (save_complete.c:242) ==28508== by 0x35507F: save_complete_save_stylesheet (save_complete.c:352) ==28508== by 0x35525B: save_complete_save_html_stylesheet (save_complete.c:402) ==28508== by 0x3552B6: save_complete_save_html_stylesheets (save_complete.c:414) ==28508== by 0x356A11: save_complete_save_html (save_complete.c:1143) ==28508== by 0x356C99: save_complete (save_complete.c:1250) ==28508== by 0x38C381: savepage_button_clicked_cb (toolbar.c:2180) ==28508== by 0x390FB5: nsgtk_toolbar_item_activate (toolbar.c:3604) ==28508== by 0x395783: nsgtk_window_item_activate (window.c:1594) ==28508== by 0x381B02: nsgtk_on_savepage_activate_menu (toolbar_items.h:115) ==28508== Address 0xf3d575f is 0 bytes after a block of size 4,815 alloc'd ==28508== at 0x483577F: malloc (vg_replace_malloc.c:299) ==28508== by 0x26AFB4: fetch (fs_backing_store.c:1987) ==28508== by 0x32C526: llcache_retrieve_persisted_data (llcache.c:1204) ==28508== by 0x32CF75: llcache_object_retrieve_from_cache (llcache.c:1655) ==28508== by 0x32D4CD: llcache_object_retrieve (llcache.c:1835) ==28508== by 0x32FFA0: llcache_handle_retrieve (llcache.c:3596) ==28508== by 0x32A723: hlcache_handle_retrieve (hlcache.c:714) ==28508== by 0x28D49D: html_css_process_link (html_css.c:454) ==28508== by 0x288C97: dom_default_action_DOMNodeInserted_cb (html.c:748) ==28508== by 0x40FA95: _dom_node_dispatch_event (in /home/vince/dev-netsurf/workspace/netsurf/nsgtk) ==28508== by 0x41800E: __dom_dispatch_node_change_event (in /home/vince/dev-netsurf/workspace/netsurf/nsgtk) ==28508== by 0x4104BD: _dom_node_dispatch_node_change_event (in /home/vince/dev-netsurf/workspace/netsurf/nsgtk) |
|
Vincent Sanders (administrator) 2019-10-21 22:59 |
fixed overrunning posix regex |
|
Vincent Sanders (administrator) 2020-05-27 08:16 |
Thankyou for reporting this issue. We believe this is fixed in the 3.10 release. If this is not the case please feel free to reopen the issue with additional details. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-08-02 14:52 | Harriet Bazley | New Issue | |
| 2019-08-02 14:52 | Harriet Bazley | File Added: new.zip | |
| 2019-10-21 09:54 | Vincent Sanders | Status | new => confirmed |
| 2019-10-21 09:54 | Vincent Sanders | Category | General => Core-specific |
| 2019-10-21 09:54 | Vincent Sanders | Steps to Reproduce Updated | View Revisions |
| 2019-10-21 09:54 | Vincent Sanders | Additional Information Updated | View Revisions |
| 2019-10-21 09:54 | Vincent Sanders | Note Added: 0002109 | |
| 2019-10-21 22:59 | Vincent Sanders | Assigned To | => Vincent Sanders |
| 2019-10-21 22:59 | Vincent Sanders | Status | confirmed => resolved |
| 2019-10-21 22:59 | Vincent Sanders | Resolution | open => fixed |
| 2019-10-21 22:59 | Vincent Sanders | Fixed in Version | => 3.10 |
| 2019-10-21 22:59 | Vincent Sanders | Fixed in CI build # | => 4875 |
| 2019-10-21 22:59 | Vincent Sanders | Note Added: 0002110 | |
| 2020-05-27 08:16 | Vincent Sanders | Status | resolved => closed |
| 2020-05-27 08:16 | Vincent Sanders | Note Added: 0002237 | |
| Issue History |