| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002663 | NetSurf | [All Projects] General | public | 2019-06-04 04:17 | 2019-07-19 08:27 | ||||
| Reporter | Michael Forney | ||||||||
| Assigned To | kinnison | ||||||||
| Severity | minor | Reproducibility | always | ||||||
| Status | closed | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | 3.9 | Fixed in Version | 3.9 | ||||||
| Summary | 0002663: curl 7.65.0 breaks HTTP redirects | ||||||||
| Description | I noticed after upgrading to 7.65.0 that HTTP redirects don't work anymore. I bisected this down to https://github.com/curl/curl/pull/3837, which prevents calls into the curl API from callbacks, since that is unsupported usage. It looks like the root of the issue is that fetch_curl_data (a curl callback) can trigger a new fetch request, which calls curl_multi_add_handle, which is now failing with CURLM_RECURSIVE_API_CALL. I think to resolve this, netsurf needs to wait until fetch_curl_done to start new requests for redirects. | ||||||||
| Steps To Reproduce | 1. Build netsurf against curl 7.65.0 2. Load a URL resulting in a redirect, such as https://httpstat.us/302 3. Request appears to hang | ||||||||
| Tags | No tags attached. | ||||||||
| Fixed in CI build # | |||||||||
| Reported in CI build # | |||||||||
| URL of problem page | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
kinnison (administrator) 2019-06-05 18:55 |
Hi, I'm unable to reproduce this myself as I don't have a new enough cURL but I've added a patch which ought to mitigate this. Could you please try running CI#4655 (or building a new version from master if that's how you're diagnosing) so that we can see if this helps. Thanks, Daniel. |
Michael Forney (reporter) 2019-06-07 04:49 |
Thanks! Your patch fixes the issue for me. |
|
kinnison (administrator) 2019-06-09 13:06 |
Thank you Michael. |
Vincent Sanders (administrator) 2019-07-19 08:27 |
we believe this issue has been resolved in NetSurf 3.9 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-06-04 04:17 | Michael Forney | New Issue | |
| 2019-06-05 18:55 | kinnison | Assigned To | => kinnison |
| 2019-06-05 18:55 | kinnison | Status | new => assigned |
| 2019-06-05 18:55 | kinnison | Note Added: 0001933 | |
| 2019-06-07 04:49 | Michael Forney | Note Added: 0001940 | |
| 2019-06-09 13:06 | kinnison | Status | assigned => resolved |
| 2019-06-09 13:06 | kinnison | Resolution | open => fixed |
| 2019-06-09 13:06 | kinnison | Fixed in Version | => 3.9 |
| 2019-06-09 13:06 | kinnison | Target Version | => 3.9 |
| 2019-06-09 13:06 | kinnison | Note Added: 0001948 | |
| 2019-07-19 08:27 | Vincent Sanders | Status | resolved => closed |
| 2019-07-19 08:27 | Vincent Sanders | Note Added: 0002004 | |
| Issue History |