| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002632 | NetSurf | [All Projects] General | public | 2019-01-14 03:42 | 2019-07-19 08:33 | ||||
| Reporter | Samuel Holland | ||||||||
| Assigned To | Vincent Sanders | ||||||||
| Severity | trivial | Reproducibility | always | ||||||
| Status | closed | Resolution | fixed | ||||||
| Platform | Linux | OS | musl | OS Version | |||||
| Product Version | |||||||||
| Target Version | Fixed in Version | 3.9 | |||||||
| Summary | 0002632: Duplicate definition of global variable in nsgenbind | ||||||||
| Description | Global variable errtxt is defined in two separate files. This is a minor C standard conformance issue, and causes the build to fail with a duplicate symbol error when CFLAGS includes "-fno-common". The following patch fixes the issue by making the variables static. --- nsgenbind-0.6/src/nsgenbind-parser.y.orig +++ nsgenbind-0.6/src/nsgenbind-parser.y @@ -91,7 +91,7 @@ typedef struct YYLTYPE { #include "webidl-ast.h" #include "nsgenbind-ast.h" -char *errtxt; +static char *errtxt; static void nsgenbind_error(YYLTYPE *locp, char *filename, --- nsgenbind-0.6/src/webidl-parser.y.orig +++ nsgenbind-0.6/src/webidl-parser.y @@ -32,7 +32,7 @@ #include "webidl-ast.h" -char *errtxt; +static char *errtxt; static void webidl_error(YYLTYPE *locp, struct webidl_node **winbind_ast, const char *str) | ||||||||
| Tags | No tags attached. | ||||||||
| Fixed in CI build # | |||||||||
| Reported in CI build # | |||||||||
| URL of problem page | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
Vincent Sanders (administrator) 2019-02-15 18:06 |
thanks for the report fix applied to nsgenbind as commit 9298fea93f101a417bbd15a879f319fcdcf41cf0 |
|
Vincent Sanders (administrator) 2019-07-19 08:33 |
we believe this issue has been resolved in NetSurf 3.9 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-01-14 03:42 | Samuel Holland | New Issue | |
| 2019-02-15 18:06 | Vincent Sanders | Assigned To | => Vincent Sanders |
| 2019-02-15 18:06 | Vincent Sanders | Status | new => resolved |
| 2019-02-15 18:06 | Vincent Sanders | Resolution | open => fixed |
| 2019-02-15 18:06 | Vincent Sanders | Fixed in Version | => 3.9 |
| 2019-02-15 18:06 | Vincent Sanders | Note Added: 0001874 | |
| 2019-07-19 08:33 | Vincent Sanders | Status | resolved => closed |
| 2019-07-19 08:33 | Vincent Sanders | Note Added: 0002022 | |
| Issue History |