2020-07-04 20:18 BST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002596NetSurf[All Projects] Generalpublic2018-08-29 14:59
ReporterRichard Porter 
Assigned ToMichael Drake 
PlatformARMX6OSRISC OSOS Version5.23
Product Version3.7 
Target Version3.8Fixed in Version3.8 
Summary0002596: Drag URL omits on-page part
DescriptionIf you follow a link containing an on-page reference (see problem page), then click and drag the URL to a document/editor/filer window/etc only the main part is included, not the on-page bit. So if you drag the URL of the problem page you will get https://railfuture.org.uk/conferences/ only.

Steps To ReproduceGo to problem page.
Drag the URL somewhere.
Additional InformationNot page-specific.
TagsNo tags attached.
Fixed in CI build #4364
Reported in CI build #4335
URL of problem pagehttps://railfuture.org.uk/conferences/#2018_reading
Attached Files

related to 0001961closed Allow foo.html#bar to still have the #bar when exporting URL 

Michael Drake


Michael Drake (administrator)

For RISC OS, this happens in frontends/riscos/window.c

In ro_gui_window_toolbar_click() we call browser_window_get_url(g->bw), which is implemented by the core.

In the core, in desktop/browser.c the browser_window_get_url() function gets the URL from the current content's hlcache_handle, using hlcache_handle_get_url().

hlcache_handle_get_url() ends up either calling content_get_url(), or llcache_handle_get_url() get URL, depending on whether the content has been fetched, but content_get_url() calls llcache_handle_get_url() anyway.

The cache/fetch layers don't care about fragments which is why they don't store them.

In desktop/browser_private.h, struct browser_window is defined. It contains a member storing frag_id.

We could modify browser_window_get_url() to call nsurl_refragment(), adding the fragment back on. However, this would create a ref, and currently the browser_window_get_url() call doesn't create a ref, so that would need to change to make all call sites free the ref.
Vincent Sanders


Vincent Sanders (administrator)

Thank you for your report, this has been resolved in the 3.8 release

-Issue History
Date Modified Username Field Change
2018-05-04 14:48 Richard Porter New Issue
2018-07-20 16:03 Michael Drake Description Updated View Revisions
2018-07-20 16:03 Michael Drake Steps to Reproduce Updated View Revisions
2018-07-20 16:03 Michael Drake Note Added: 0001778
2018-07-23 11:43 Michael Drake Assigned To => Michael Drake
2018-07-23 11:43 Michael Drake Status new => resolved
2018-07-23 11:43 Michael Drake Resolution open => fixed
2018-07-23 11:43 Michael Drake Product Version => 3.7
2018-07-23 11:43 Michael Drake Fixed in Version => 3.8
2018-07-23 11:43 Michael Drake Target Version => 3.8
2018-07-23 11:43 Michael Drake Fixed in CI build # => 4364
2018-07-27 10:36 Vincent Sanders Relationship added related to 0001961
2018-08-29 14:59 Vincent Sanders Status resolved => closed
2018-08-29 14:59 Vincent Sanders Note Added: 0001825
+Issue History