2018-11-19 09:56 UTC

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002491NetSurf[All Projects] Generalpublic2018-07-29 10:20
ReporterChris Young 
Assigned ToDaniel Silverstone 
SeverityminorReproducibilityhave not tried 
StatusconfirmedResolutionopen 
PlatformAmigaOSAmigaOSOS Version3.5
Product Version 
Target VersionFixed in Version 
Summary0002491: Memory leaks in libdom
DescriptionI've built the Amiga frontend of NetSurf with clib's memory debugging mode. This logs memory allocations and will note when they haven't been freed.

See bug 2489 for more info.

For libdom, we have the following not freed:
src/core/string.c:101 (0000390:0000016 bytes)
src/core/string.c:105 (various sizes)
Steps To ReproduceThis is a simple open/close NetSurf only viewing about:welcome
Additional InformationRelevant part of log:

[NetSurf] - 16 0x1164D610 [allocated at src/core/string.c:101, freed at stdlib_malloc.c:399]
[NetSurf] - 4 0x1164DE48 [allocated at src/core/string.c:105, freed at stdlib_malloc.c:399]
[NetSurf] - 16 0x1164E680 [allocated at src/core/string.c:101, freed at stdlib_malloc.c:399]
[NetSurf] - 6 0x1164EEB8 [allocated at src/core/string.c:105, freed at stdlib_malloc.c:399]
[NetSurf] - 16 0x1164F6F0 [allocated at src/core/string.c:101, freed at stdlib_malloc.c:399]
[NetSurf] - 29 0x1164FF28 [allocated at src/core/string.c:105, freed at stdlib_malloc.c:399]
[NetSurf] - 16 0x11650760 [allocated at src/core/string.c:101, freed at stdlib_malloc.c:399]
[NetSurf] - 35 0x11650F98 [allocated at src/core/string.c:105, freed at stdlib_malloc.c:399]
[NetSurf] - 16 0x116517D0 [allocated at src/core/string.c:101, freed at stdlib_malloc.c:399]
[NetSurf] - 27 0x11652008 [allocated at src/core/string.c:105, freed at stdlib_malloc.c:399]
[NetSurf] - 16 0x11652840 [allocated at src/core/string.c:101, freed at stdlib_malloc.c:399]
[NetSurf] - 29 0x11653078 [allocated at src/core/string.c:105, freed at stdlib_malloc.c:399]
[NetSurf] - 16 0x116538B0 [allocated at src/core/string.c:101, freed at stdlib_malloc.c:399]
[NetSurf] - 37 0x116540E8 [allocated at src/core/string.c:105, freed at stdlib_malloc.c:399]
[NetSurf] - 16 0x11654920 [allocated at src/core/string.c:101, freed at stdlib_malloc.c:399]
[NetSurf] - 30 0x11655158 [allocated at src/core/string.c:105, freed at stdlib_malloc.c:399]
TagsNo tags attached.
Fixed in CI build #
Reported in CI build #3794
URL of problem page
Attached Files

-Relationships
related to 0002489confirmed Memory leaks 
+Relationships

-Notes
Chris Young

~0001455

Chris Young (developer)

I put this down as a libdom bug, but after a quick look I think libdom is OK, and it's NetSurf not destroying the strings.
Vincent Sanders

~0001466

Vincent Sanders (administrator)

looks like netsurf has some dom strings still referenced.

Right sod to track down without explicit dump code to show what they are.
Michael Drake

~0001480

Michael Drake (administrator)

They won't be interned dom strings, or the wapcaplet exit iterator would list them. I'd be tempted to do a quick hack to libdom, to make it intern all strings, run with that, and have the wapcaplet iterator tell us what they are.
Vincent Sanders

~0001791

Vincent Sanders (administrator)

daniel has been looking at several libdom leaks revealed by the sanitizer checks
+Notes

-Issue History
Date Modified Username Field Change
2016-12-05 23:53 Chris Young New Issue
2016-12-05 23:53 Chris Young Relationship added related to 0002489
2016-12-06 00:22 Chris Young Project LibDOM => NetSurf
2016-12-06 00:24 Chris Young Note Added: 0001455
2016-12-31 12:28 Vincent Sanders Note Added: 0001466
2016-12-31 12:28 Vincent Sanders Status new => acknowledged
2017-01-06 10:19 Michael Drake Note Added: 0001480
2018-07-29 10:20 Vincent Sanders Assigned To => Daniel Silverstone
2018-07-29 10:20 Vincent Sanders Status acknowledged => confirmed
2018-07-29 10:20 Vincent Sanders Note Added: 0001791
+Issue History