| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 0002383 | NetSurf | Javascript | public | 2015-11-06 20:15 | 2019-06-05 21:06 | ||||||||
| Reporter | Chris Young | ||||||||||||
| Assigned To | kinnison | ||||||||||||
| Severity | minor | Reproducibility | always | ||||||||||
| Status | confirmed | Resolution | open | ||||||||||
| Platform | Amiga | OS | AmigaOS | OS Version | 4.1 | ||||||||
| Product Version | 3.4 | ||||||||||||
| Target Version | 4.0 | Fixed in Version | |||||||||||
| Summary | 0002383: Website displaying without CSS | ||||||||||||
| Description | Digital Spy is loading with no stylesheet. | ||||||||||||
| Steps To Reproduce | Visit http://www.digitalspy.com | ||||||||||||
| Additional Information | I can't see any mention of css files beyond the default NetSurf ones in the log. I know when they changed their site it went to a heavily Javascripted design, so it wouldn't surprise me if it is trying to do something clever we don't support yet. A quick glance at the code reveals it's using "Modernizr" to create the stylesheets using Javascript. | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Fixed in CI build # | |||||||||||||
| Reported in CI build # | 3053 | ||||||||||||
| URL of problem page | http://www.digitalspy.com | ||||||||||||
| Attached Files |
| ||||||||||||
 Relationships |
|
 Relationships |
| Notes |
|
Vincent Sanders (administrator) 2015-11-08 10:08 |
the site uses the following script to insert its css with javascript. var s, el; s = document.createElement('link'); s.rel = "stylesheet"; s.href = '//digitalspyuk.cdnds.net/digitalspyuk/20151103130454/css/main' + ( Modernizr.mobile ? '-mobile.css' : '.css' ); el = document.getElementById('write-styles'); document.getElementsByTagName("head")[0].insertBefore( s, el ); |
kinnison (administrator) 2015-11-08 13:52 |
This is using a numeric indexing into the html collection returned by document.getElementsByTagName("head") which is daft (document.head would be faster) Sadly until we do ES6 proxy support for collections this won't work. |
|
kinnison (administrator) 2015-11-08 17:14 |
In addition, the Modernizr stuff looks like CSSOM |
|
kinnison (administrator) 2019-06-05 21:06 |
Current state of play, we have proxy support so that bit works, but the CSSOM still won't. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-11-06 20:15 | Chris Young | New Issue | |
| 2015-11-06 20:15 | Chris Young | File Added: ns.log | |
| 2015-11-07 13:54 | Chris Young | Category | Layout => Javascript |
| 2015-11-07 13:54 | Chris Young | Additional Information Updated | View Revisions |
| 2015-11-08 10:08 | Vincent Sanders | Note Added: 0001040 | |
| 2015-11-08 10:08 | Vincent Sanders | Status | new => confirmed |
| 2015-11-08 10:08 | Vincent Sanders | Additional Information Updated | View Revisions |
| 2015-11-08 13:52 | kinnison | Note Added: 0001041 | |
| 2015-11-08 14:44 | kinnison | Assigned To | => kinnison |
| 2015-11-08 14:44 | kinnison | Status | confirmed => assigned |
| 2015-11-08 14:44 | kinnison | Status | assigned => confirmed |
| 2015-11-08 17:14 | kinnison | Note Added: 0001042 | |
| 2016-02-09 11:05 | Michael Drake | Target Version | 3.4 => 4.0 |
| 2019-06-05 21:06 | kinnison | Note Added: 0001935 | |
| Issue History |