2019-12-06 21:52 UTC

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002383NetSurfJavascriptpublic2019-06-05 21:06
ReporterChris Young 
Assigned ToDaniel Silverstone 
SeverityminorReproducibilityalways 
StatusconfirmedResolutionopen 
PlatformAmigaOSAmigaOSOS Version4.1
Product Version3.4 
Target Version4.0Fixed in Version 
Summary0002383: Website displaying without CSS
DescriptionDigital Spy is loading with no stylesheet.
Steps To ReproduceVisit http://www.digitalspy.com
Additional InformationI can't see any mention of css files beyond the default NetSurf ones in the log. I know when they changed their site it went to a heavily Javascripted design, so it wouldn't surprise me if it is trying to do something clever we don't support yet.

A quick glance at the code reveals it's using "Modernizr" to create the stylesheets using Javascript.
TagsNo tags attached.
Fixed in CI build #
Reported in CI build #3053
URL of problem pagehttp://www.digitalspy.com
Attached Files
  • log file icon ns.log (265,738 bytes) 2015-11-06 20:15

-Relationships
+Relationships

-Notes
Vincent Sanders

~0001040

Vincent Sanders (administrator)

the site uses the following script to insert its css with javascript.



var s, el;

s = document.createElement('link');
s.rel = "stylesheet";
s.href = '//digitalspyuk.cdnds.net/digitalspyuk/20151103130454/css/main' + ( Modernizr.mobile ? '-mobile.css' : '.css' );
el = document.getElementById('write-styles');

document.getElementsByTagName("head")[0].insertBefore( s, el );
Daniel Silverstone

~0001041

Daniel Silverstone (administrator)

This is using a numeric indexing into the html collection returned by document.getElementsByTagName("head") which is daft (document.head would be faster)

Sadly until we do ES6 proxy support for collections this won't work.
Daniel Silverstone

~0001042

Daniel Silverstone (administrator)

In addition, the Modernizr stuff looks like CSSOM
Daniel Silverstone

~0001935

Daniel Silverstone (administrator)

Current state of play, we have proxy support so that bit works, but the CSSOM still won't.
+Notes

-Issue History
Date Modified Username Field Change
2015-11-06 20:15 Chris Young New Issue
2015-11-06 20:15 Chris Young File Added: ns.log
2015-11-07 13:54 Chris Young Category Layout => Javascript
2015-11-07 13:54 Chris Young Additional Information Updated View Revisions
2015-11-08 10:08 Vincent Sanders Note Added: 0001040
2015-11-08 10:08 Vincent Sanders Status new => confirmed
2015-11-08 10:08 Vincent Sanders Additional Information Updated View Revisions
2015-11-08 13:52 Daniel Silverstone Note Added: 0001041
2015-11-08 14:44 Daniel Silverstone Assigned To => Daniel Silverstone
2015-11-08 14:44 Daniel Silverstone Status confirmed => assigned
2015-11-08 14:44 Daniel Silverstone Status assigned => confirmed
2015-11-08 17:14 Daniel Silverstone Note Added: 0001042
2016-02-09 11:05 Michael Drake Target Version 3.4 => 4.0
2019-06-05 21:06 Daniel Silverstone Note Added: 0001935
+Issue History