View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0002322 | NetSurf | [All Projects] General | public | 2015-05-31 20:53 | 2016-02-16 14:43 | ||||
Reporter | Chris Young | ||||||||
Assigned To | Daniel Silverstone | ||||||||
Severity | crash | Reproducibility | always | ||||||
Status | closed | Resolution | fixed | ||||||
Platform | Amiga | OS | AmigaOS | OS Version | 4.1 | ||||
Product Version | 3.4 | ||||||||
Target Version | 3.4 | Fixed in Version | 3.4 | ||||||
Summary | 0002322: Crash in form_free_control | ||||||||
Description | Crash in form_free_control when visiting https://boardgamegeek.com/boardgame/15817/manila | ||||||||
Steps To Reproduce | Visit https://boardgamegeek.com/boardgame/15817/manila | ||||||||
Additional Information | Stack trace: [render/form.c:256] form_free_control()+0x80 (section 1 @ 0xCC8A0) [render/form.c:224] form_free_control()+0x58 (section 1 @ 0xCC878) [render/box_construct.c:871] convert_xml_to_box()+0x5d4 (section 1 @ 0xC6708) [amiga/schedule.c:239] ami_schedule_handle()+0x178 (section 1 @ 0x385EC) [amiga/gui.c:2801] ami_get_msg()+0x5e8 (section 1 @ 0x1D0BC) [amiga/gui.c:5539] main()+0xb40 (section 1 @ 0x2081C) native kernel module newlib.library.kmod+0x000020ac native kernel module newlib.library.kmod+0x00002d5c native kernel module newlib.library.kmod+0x00002ef0 _start()+0x170 (section 1 @ 0x16C) native kernel module dos.library.kmod+0x00024c18 native kernel module kernel+0x0003b648 native kernel module kernel+0x0003b6c8 | ||||||||
Tags | No tags attached. | ||||||||
Fixed in CI build # | 2788 | ||||||||
Reported in CI build # | 2785 | ||||||||
URL of problem page | https://boardgamegeek.com/boardgame/15817/manila | ||||||||
Attached Files |
|
Notes | |
Vincent Sanders (administrator) 2015-06-01 01:14 |
reproducible on gtk too (gdb) run Starting program: /home/vince/dev-netsurf/workspace/netsurf/nsgtk https://boardgamegeek.com/boardgame/15817/manila warning: no loadable sections found in added symbol-file system-supplied DSO at 0x7ffff7ffa000 [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". [New Thread 0x7fffe9b92700 (LWP 6154)] [New Thread 0x7fffe3079700 (LWP 6155)] [New Thread 0x7fffe2878700 (LWP 6156)] [New Thread 0x7fffe1e3c700 (LWP 6157)] [New Thread 0x7fffe163b700 (LWP 6158)] [New Thread 0x7fffe0e3a700 (LWP 6159)] [New Thread 0x7fffdbfff700 (LWP 6160)] [Thread 0x7fffdbfff700 (LWP 6160) exited] [Thread 0x7fffe3079700 (LWP 6155) exited] [Thread 0x7fffe0e3a700 (LWP 6159) exited] Program received signal SIGSEGV, Segmentation fault. 0x00000000004e4aeb in form_free_control (control=0x1db1780) at render/form.c:256 256 for (c = control->form->controls; c != NULL; c = c->next) { (gdb) p control $1 = (struct form_control *) 0x1db1780 (gdb) p control->form $2 = (struct form *) 0x0 (gdb) p *control $3 = {node = 0x18ee340, html = 0x1237500, type = GADGET_SELECT, form = 0x0, name = 0x0, value = 0x0, initial_value = 0x0, disabled = false, box = 0x0, length = 0, maxlength = 0, selected = false, data = { image = {mx = 0, my = 0}, select = {num_items = 0, items = 0x0, last_item = 0x0, multiple = false, num_selected = 0, current = 0x0, menu = 0x0}, text = {ta = 0x0, initial = 0x0, data = {gadget = 0x0}}}, prev = 0x0, next = 0x0} |
Daniel Silverstone (administrator) 2015-06-03 20:41 |
Slight bug in the form_free_control() routine which wasn't checking that the form was non-NULL before iterating it. |
Vincent Sanders (administrator) 2016-02-16 14:43 Last edited: 2016-02-16 14:43 |
Confirmed fixed in 3.4 release |
Issue History | |||
Date Modified | Username | Field | Change |
---|---|---|---|
2015-05-31 20:53 | Chris Young | New Issue | |
2015-06-01 01:14 | Vincent Sanders | Note Added: 0000853 | |
2015-06-01 01:15 | Vincent Sanders | Assigned To | => Daniel Silverstone |
2015-06-01 01:15 | Vincent Sanders | Status | new => confirmed |
2015-06-01 01:15 | Vincent Sanders | Description Updated | View Revisions |
2015-06-01 01:15 | Vincent Sanders | Additional Information Updated | View Revisions |
2015-06-03 20:41 | Daniel Silverstone | Fixed in CI build # | => 2788 |
2015-06-03 20:41 | Daniel Silverstone | Note Added: 0000858 | |
2015-06-03 20:41 | Daniel Silverstone | Status | confirmed => resolved |
2015-06-03 20:41 | Daniel Silverstone | Fixed in Version | => 3.4 |
2015-06-03 20:41 | Daniel Silverstone | Target Version | => 3.4 |
2015-10-31 21:44 | Vincent Sanders | Resolution | open => fixed |
2016-02-16 14:43 | Vincent Sanders | Note Added: 0001272 | |
2016-02-16 14:43 | Vincent Sanders | Status | resolved => closed |
2016-02-16 14:43 | Vincent Sanders | Note Edited: 0001272 | View Revisions |