View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0002536 | LibCSS | LibCSS | public | 2017-05-08 03:37 | 2020-05-27 08:23 | ||||
Reporter | Alastair Hughes | ||||||||
Assigned To | |||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | x86_64 | OS | Custom linux | OS Version | |||||
Summary | 0002536: Build failure with GCC 7.1 due to implicit-fallthrough | ||||||||
Description | Building with GCC 7.1 fails due to the newly-added implicit-fallthrough feature. Some case statements in libcss's parser have a "Fall through" comment but are inside an additional set of braces, which prevents GCC's comment detection working and triggers a warning, which causes the build to fail. An example of this is seen at http://git.netsurf-browser.org/libcss.git/tree/src/parse/parse.c#n2094. https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html describes the new behavior. I have attached a patch which fixes this issue by removing the braces. | ||||||||
Steps To Reproduce | Attempt to build libcss using GCC 7.1 | ||||||||
Tags | No tags attached. | ||||||||
Fixed in CI build # | |||||||||
Reported in CI build # | |||||||||
Attached Files |
|
![]() |
|
Vincent Sanders (administrator) 2020-05-27 08:23 |
Thankyou for reporting this issue. We believe this is fixed in the 3.10 release. If this is not the case please feel free to reopen the issue with additional details. |
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2017-05-08 03:37 | Alastair Hughes | New Issue | |
2017-05-08 03:37 | Alastair Hughes | File Added: 0001-Remove-extra-braces-to-fix-build-with-gcc-7.patch | |
2018-04-21 08:24 | Michael Drake | Status | new => resolved |
2018-04-21 08:24 | Michael Drake | Resolution | open => fixed |
2020-05-27 08:23 | Vincent Sanders | Status | resolved => closed |
2020-05-27 08:23 | Vincent Sanders | Note Added: 0002261 |