MantisBT - LibCSS |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0002536 | LibCSS | LibCSS | public | 2017-05-08 03:37 | 2020-05-27 08:23 |
|
Reporter | Alastair Hughes | |
---|
Assigned To | | |
---|
Priority | normal | Severity | minor | Reproducibility | always |
---|
Status | closed | Resolution | fixed | |
---|
Platform | x86_64 | OS | Custom linux | OS Version | |
---|
Fixed in CI build # | |
---|
Reported in CI build # | |
---|
|
Summary | 0002536: Build failure with GCC 7.1 due to implicit-fallthrough |
---|
Description | Building with GCC 7.1 fails due to the newly-added implicit-fallthrough feature. Some case statements in libcss's parser have a "Fall through" comment but are inside an additional set of braces, which prevents GCC's comment detection working and triggers a warning, which causes the build to fail. An example of this is seen at http://git.netsurf-browser.org/libcss.git/tree/src/parse/parse.c#n2094.
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html describes the new behavior.
I have attached a patch which fixes this issue by removing the braces. |
---|
Steps To Reproduce | Attempt to build libcss using GCC 7.1 |
---|
Tags | No tags attached. |
---|
Relationships | |
Attached Files | 0001-Remove-extra-braces-to-fix-build-with-gcc-7.patch (1,743) 2017-05-08 03:37 https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=494&type=bug |
---|