MantisBT - LibCSS
View Issue Details
0002536LibCSSLibCSSpublic2017-05-08 03:372020-05-27 08:23
ReporterAlastair Hughes 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
Platformx86_64OSCustom linuxOS Version
Fixed in CI build #
Reported in CI build #
Summary0002536: Build failure with GCC 7.1 due to implicit-fallthrough
DescriptionBuilding with GCC 7.1 fails due to the newly-added implicit-fallthrough feature. Some case statements in libcss's parser have a "Fall through" comment but are inside an additional set of braces, which prevents GCC's comment detection working and triggers a warning, which causes the build to fail. An example of this is seen at http://git.netsurf-browser.org/libcss.git/tree/src/parse/parse.c#n2094.

https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html describes the new behavior.

I have attached a patch which fixes this issue by removing the braces.
Steps To ReproduceAttempt to build libcss using GCC 7.1
TagsNo tags attached.
Attached Filespatch 0001-Remove-extra-braces-to-fix-build-with-gcc-7.patch (1,743) 2017-05-08 03:37
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=494&type=bug

Notes
(0002261)
Vincent Sanders   
2020-05-27 08:23   
Thankyou for reporting this issue.
We believe this is fixed in the 3.10 release.
If this is not the case please feel free to reopen the issue with additional details.

Issue History
2017-05-08 03:37Alastair HughesNew Issue
2017-05-08 03:37Alastair HughesFile Added: 0001-Remove-extra-braces-to-fix-build-with-gcc-7.patch
2018-04-21 08:24Michael DrakeStatusnew => resolved
2018-04-21 08:24Michael DrakeResolutionopen => fixed
2020-05-27 08:23Vincent SandersStatusresolved => closed
2020-05-27 08:23Vincent SandersNote Added: 0002261