2020-09-23 11:55 BST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002788NetSurfWin32-specificpublic2020-08-16 23:52
ReporterSven Knurr 
Assigned ToVincent Sanders 
SeverityfeatureReproducibilityN/A 
StatusresolvedResolutionopen 
Product Version3.10 
Target Version3.11Fixed in Version3.11 
Summary0002788: Support Ctrl+A in the address bar
DescriptionIt is not quite good that the Win32 version of NetSurf does not understand Ctrl+A to select everything in the URL bar. It really should.
Additional InformationPotential patch attached.
TagsNo tags attached.
Fixed in CI build #
Reported in CI build #
URL of problem page
Attached Files
  • diff file icon patch.diff (560 bytes) 2020-08-13 09:28 -
    diff --git a/frontends/windows/window.c b/frontends/windows/window.c
    index e192191bb..750c57703 100644
    --- a/frontends/windows/window.c
    +++ b/frontends/windows/window.c
    @@ -416,7 +416,11 @@ nsws_window_urlbar_callback(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam)
     	/* override messages */
     	switch (msg) {
     	case WM_CHAR:
    -		if (wparam == 13) {
    +		if (wparam == 1) {
    +			/* handle ^A */
    +			SendMessage(hwnd, EM_SETSEL, 0, -1);
    +			return 1;
    +		} else if (wparam == 13) {
     			SendMessage(gw->main, WM_COMMAND, IDC_MAIN_LAUNCH_URL, 0);
     			return 0;
     		}
    
    diff file icon patch.diff (560 bytes) 2020-08-13 09:28 +

-Relationships
+Relationships

-Notes
Vincent Sanders

~0002287

Vincent Sanders (administrator)

applied patch http://git.netsurf-browser.org/netsurf.git/commit/?id=1ea47f9caf702abac0d96795b2502e438086aeed

Thankyou for the contribution
+Notes

-Issue History
Date Modified Username Field Change
2020-08-13 09:28 Sven Knurr New Issue
2020-08-13 09:28 Sven Knurr File Added: patch.diff
2020-08-16 23:52 Vincent Sanders Assigned To => Vincent Sanders
2020-08-16 23:52 Vincent Sanders Status new => resolved
2020-08-16 23:52 Vincent Sanders Fixed in Version => 3.11
2020-08-16 23:52 Vincent Sanders Target Version => 3.11
2020-08-16 23:52 Vincent Sanders Note Added: 0002287
+Issue History