2020-10-20 22:09 BST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002730NetSurfDevelopmentpublic2020-02-21 09:42
ReporterAnthony J. Bentley 
Assigned To 
SeveritytextReproducibilityN/A 
StatusclosedResolutionwon't fix 
Product Version 
Target VersionFixed in Version 
Summary0002730: typo: "testment"
Descriptiongit-testament.pl uses "testament" all throughout, except two instances where it spells it "testment." Patch attached.
TagsNo tags attached.
Fixed in CI build #
Reported in CI build #
URL of problem page
Attached Files
  • diff file icon netsurf-testament.diff (832 bytes) 2019-12-25 10:09 -
    commit 08fc97aec5ec7ada204c9e9aa9d12400fd587c37
    Author: Anthony J. Bentley <anthony@roadrunner.page>
    Date:   Wed Dec 25 03:05:12 2019 -0700
    
        Fix typo: "testment" to "testament"
    
    diff --git a/utils/git-testament.pl b/utils/git-testament.pl
    index 5a71a16df..a748b14bf 100644
    --- a/utils/git-testament.pl
    +++ b/utils/git-testament.pl
    @@ -183,7 +183,7 @@ if ( -e $targetfile ) {
     my $newcsum = compat_md5_hex($testament);
     
     if ($oldcsum ne $newcsum) {
    -   print "TESTMENT: $targetfile\n";
    +   print "TESTAMENT: $targetfile\n";
        open(my $NEWVALUES, ">", $targetfile) or die "$!";
        print $NEWVALUES "/* ", $targetfile,"\n";
        print $NEWVALUES <<'EOS';
    @@ -211,7 +211,7 @@ EOS
             system("rm", "-f", "--", $unwanted);
          }
     } else {
    -   print "TESTMENT: unchanged\n";
    +   print "TESTAMENT: unchanged\n";
     }
     
     exit 0;
    
    diff file icon netsurf-testament.diff (832 bytes) 2019-12-25 10:09 +

-Relationships
+Relationships

-Notes
Daniel Silverstone

~0002165

Daniel Silverstone (administrator)

The use of `TESTMENT` is to align output in the makefile. Thank you for your concern, but we will not be applying this patch.
+Notes

-Issue History
Date Modified Username Field Change
2019-12-25 10:09 Anthony J. Bentley New Issue
2019-12-25 10:09 Anthony J. Bentley File Added: netsurf-testament.diff
2020-02-21 09:42 Daniel Silverstone Status new => closed
2020-02-21 09:42 Daniel Silverstone Resolution open => won't fix
2020-02-21 09:42 Daniel Silverstone Note Added: 0002165
+Issue History