| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002578 | NetSurf | Amiga-specific | public | 2017-11-23 22:06 | 2020-06-01 23:46 | ||||
| Reporter | Chris Young | ||||||||
| Assigned To | Chris Young | ||||||||
| Severity | minor | Reproducibility | always | ||||||
| Status | resolved | Resolution | fixed | ||||||
| Platform | Amiga | OS | AmigaOS | OS Version | 4.1 | ||||
| Product Version | 3.8 | ||||||||
| Target Version | 3.11 | Fixed in Version | 3.11 | ||||||
| Summary | 0002578: Unable to type using Amiga-1251 charset | ||||||||
| Description | When Locale is set to the Amiga-1251 character set, it is impossible to type anything into NetSurf! | ||||||||
| Steps To Reproduce | Set Locale to Russian, Amiga-1251, open NetSurf and type something in the web page. | ||||||||
| Additional Information | This is caused by libiconv not being aware of this old Amiga-specific character set. | ||||||||
| Tags | No tags attached. | ||||||||
| Fixed in CI build # | 5170 | ||||||||
| Reported in CI build # | 4249 | ||||||||
| URL of problem page | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
Chris Young (developer) 2017-11-23 22:09 |
A workaround is to use the ISO-8859-5 character set for the system rather than the old Amiga-1251. (this is not an option on OS3) The solution will be to rewrite utf8_from/to_local to use codesets.library instead, which is aware of these old weird character sets. |
|
Chris Young (developer) 2017-12-09 18:27 |
A second workaround is to set local_charset:Windows-1251 in choices. This overrides what NetSurf thinks the system charset is, there are minimal differences between Amiga-1251 and Windows-1251 and iconv knows of the latter. |
Vincent Sanders (administrator) 2019-07-01 13:01 |
I removed this as targeted for 3.9 as that release is now and this bug remains unfixed |
|
Chris Young (developer) 2020-05-26 15:17 |
Modified charset conversion code to use codesets.library and fall back to iconv if not available. OS3 now gets Codesets' auto detection of the local charset (there is no way of overriding this currently). OS4 uses the codeset number from the current locale (Codesets was not determining this correctly so it is set manually). Have tested in Russian Amiga-1251 and both input and output is working correctly. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-11-23 22:06 | Chris Young | New Issue | |
| 2017-11-23 22:06 | Chris Young | Status | new => assigned |
| 2017-11-23 22:06 | Chris Young | Assigned To | => Chris Young |
| 2017-11-23 22:09 | Chris Young | Status | assigned => confirmed |
| 2017-11-23 22:09 | Chris Young | Note Added: 0001689 | |
| 2017-12-09 18:27 | Chris Young | Note Added: 0001692 | |
| 2018-08-28 11:40 | Vincent Sanders | Target Version | 3.8 => 3.9 |
| 2019-07-01 13:01 | Vincent Sanders | Target Version | 3.9 => |
| 2019-07-01 13:01 | Vincent Sanders | Note Added: 0001982 | |
| 2020-05-26 15:17 | Chris Young | Status | confirmed => resolved |
| 2020-05-26 15:17 | Chris Young | Resolution | open => fixed |
| 2020-05-26 15:17 | Chris Young | Fixed in Version | => 3.11 |
| 2020-05-26 15:17 | Chris Young | Fixed in CI build # | => 5170 |
| 2020-05-26 15:17 | Chris Young | Note Added: 0002203 | |
| 2020-05-27 09:02 | Vincent Sanders | Status | resolved => closed |
| 2020-05-27 09:25 | Vincent Sanders | Status | closed => resolved |
| 2020-05-27 09:25 | Vincent Sanders | Target Version | => 3.11 |
| Issue History |