2024-05-03 11:12 BST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002197NetSurfBeOS-specificpublic2016-02-16 15:25
ReporterPulkoMandy 
Assigned ToMichael Drake 
SeveritycrashReproducibilityalways 
StatusclosedResolutionno change required 
PlatformHaikuOSHaikuOS VersionNightly
Product Version3.2 
Target VersionFixed in Version3.4 
Summary0002197: Assertion fail when rendering whatif.xkcd.com
Description        0x718b2710 0x11afbc1 nscss_compute_font_size(void*, const css_hint*, css_hint*) + 0x191 (/sources/netsurf-3.2/css/select.c:429)

        state: Call (size->status != CSS_FONT_SIZE_INHERIT)
Steps To ReproduceBrowse to http://whatif.xkcd.com with asserts enabled.
TagsNo tags attached.
Fixed in CI build #
Reported in CI build #
URL of problem pagehttp://whatif.xkcd.com
Attached Files

-Relationships
+Relationships

-Notes
Vincent Sanders

~0000525

Vincent Sanders (administrator)

I cannot reproduce this with the framebuffer frontend either 3.3 development tip or a 3.2 checkout.

Does this still occur for you in this site? or has the site changed?
PulkoMandy

~0000526

PulkoMandy (reporter)

Hi,
I downloaded the latest CI build for Haiku and it does not crash, but I don't know if asserts are enabled there.

The crash still occurs with the release version of NetSurf 3.2 for Haiku so the site didn't change. I think already when I reported this we noticed it was reproductible only on Haiku.
Vincent Sanders

~0000593

Vincent Sanders (administrator)

all CI builds have asserts enabled.

Closing this as I believe tlsa css updates fixed it since 3.2 release. If it reoccurs with 3.3 please feel free to reopen
Vincent Sanders

~0000798

Vincent Sanders (administrator)

reopend as PulkoMandy says it is still happening on 3.3
PulkoMandy

~0000919

PulkoMandy (reporter)

Still happening here on commit fea40a0a78a70a29573bbdc940ea6f9ccdb6093b.
Michael Drake

~0000925

Michael Drake (administrator)

I can't reproduce it either. It might help if you could reduce it to a minimal HTML/CSS test cases that causes the problem.
PulkoMandy

~0000926

PulkoMandy (reporter)

Yes, I will try that (the page isn't ver y complex anyway). Could it be specific to the fonts or CSS files used in the BeOS port? I noticed http://git.netsurf-browser.org/netsurf.git/tree/beos/res/beosdefault.css which doesn't seem to have an equivalent in the other ports, but I'm not sure it is still used.
Michael Drake

~0000927

Michael Drake (administrator)

Unlikely, there are no form elements on that page (or the page I get served, anyway), and the BeOS CSS rules are all for form elements.
PulkoMandy

~0000928

PulkoMandy (reporter)

Ok, the problem is in the CSS for this page which sets the "html" element to be font:inherit.
This will reproduce the crash for me:

<!DOCTYPE html>
<html style="font:inherit">
  <head>
    <meta charset="utf-8" />
    <title>Jupiter Descending</title>
  </head>

  <body>
  </body>
</html>
Michael Drake

~0000929

Michael Drake (administrator)

That test case works here.

HTML is the root element, so in LibCSS in css_select_style, it goes through the computed style and sets any property which is set to inherit to its initial value. For the font-size property, that happens in css__initial_font_size, which sets it to medium.

So I don't see how that assert can happen. Is your libcss up-to-date?
PulkoMandy

~0000930

PulkoMandy (reporter)

Yes, I hit this problem with a fresh checkout and build of NetSurf, using the env.sh script. So everything is up to date (libcss is at commit f6f52757684709f7b09ed68b534226ae31633bce)
PulkoMandy

~0000931

PulkoMandy (reporter)

Ok, after further investigation, this only happens if libcss is built with gcc2. I will be using gcc4 from now on because of duktape anyway, so we can probably close this. Unless mmu_man wants to insist on BeOS and gcc2 support, that is.
Vincent Sanders

~0001298

Vincent Sanders (administrator)

Confirmed resolved in 3.4 release
+Notes

-Issue History
Date Modified Username Field Change
2014-09-09 08:29 PulkoMandy New Issue
2014-09-09 08:29 PulkoMandy File Added: NetSurf-1695-debug-09-09-2014-07-18-51.report
2014-09-14 12:14 Vincent Sanders Status new => acknowledged
2014-11-05 16:45 Vincent Sanders Note Added: 0000525
2014-11-05 16:45 Vincent Sanders Status acknowledged => feedback
2014-11-05 17:05 PulkoMandy Note Added: 0000526
2014-11-05 17:05 PulkoMandy Status feedback => new
2014-11-05 21:07 Vincent Sanders Status new => acknowledged
2015-01-30 17:27 Vincent Sanders URL of problem page ttp://whatif.xkcd.com => http://whatif.xkcd.com
2015-01-30 17:27 Vincent Sanders Note Added: 0000593
2015-01-30 17:27 Vincent Sanders Assigned To => Vincent Sanders
2015-01-30 17:27 Vincent Sanders Status acknowledged => closed
2015-01-30 17:27 Vincent Sanders Resolution open => no change required
2015-01-30 17:27 Vincent Sanders Fixed in Version => 3.3
2015-01-30 17:27 Vincent Sanders Target Version => 3.3
2015-03-21 20:00 Vincent Sanders Note Added: 0000798
2015-03-21 20:00 Vincent Sanders Status closed => confirmed
2015-03-21 20:00 Vincent Sanders Category Layout => BeOS-specific
2015-03-21 20:00 Vincent Sanders Fixed in Version 3.3 =>
2015-03-21 20:00 Vincent Sanders Target Version 3.3 => 3.4
2015-08-17 19:34 PulkoMandy Note Added: 0000919
2015-08-18 11:14 Michael Drake Note Added: 0000925
2015-08-18 11:29 PulkoMandy Note Added: 0000926
2015-08-18 14:04 Michael Drake Note Added: 0000927
2015-08-18 17:44 PulkoMandy Note Added: 0000928
2015-08-18 19:18 Michael Drake Note Added: 0000929
2015-08-19 06:23 PulkoMandy Note Added: 0000930
2015-08-19 17:47 PulkoMandy Note Added: 0000931
2015-08-20 09:44 Michael Drake Assigned To Vincent Sanders => Michael Drake
2015-08-20 09:44 Michael Drake Status confirmed => resolved
2015-08-20 09:44 Michael Drake Target Version 3.4 =>
2016-02-16 15:25 Vincent Sanders Note Added: 0001298
2016-02-16 15:25 Vincent Sanders Status resolved => closed
2016-02-16 15:25 Vincent Sanders Fixed in Version => 3.4
+Issue History