| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002140 | NetSurf | Layout | public | 2014-06-09 11:03 | 2015-03-10 11:05 | ||||
| Reporter | kinnison | ||||||||
| Assigned To | Chris Young | ||||||||
| Severity | crash | Reproducibility | have not tried | ||||||
| Status | closed | Resolution | fixed | ||||||
| Platform | RISC OS | OS | ? | OS Version | ? | ||||
| Product Version | 3.1 | ||||||||
| Target Version | 3.2 | Fixed in Version | 3.2 | ||||||
| Summary | 0002140: Poor/invalid URLs can cause the layout engine to stop after IDNA code merge | ||||||||
| Description | As summary | ||||||||
| Steps To Reproduce | Unknown as yet, Bob Latham's intranet triggers this a lot. Perhaps a test case can be constructed. | ||||||||
| Additional Information | Some people have shown failures of this ilk with unprocessed SSI in links. We may be able to use that to track down the issue. | ||||||||
| Tags | No tags attached. | ||||||||
| Fixed in CI build # | 1962 | ||||||||
| Reported in CI build # | 1959 | ||||||||
| URL of problem page | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
Vincent Sanders (administrator) 2014-06-09 12:31 |
This appears to be because the dom to box conversion fails when broken urls are processed instead of our previous behaviour of swallowing the garbage wholesale |
Chris Young (developer) 2014-06-09 13:55 |
nsurl_create now fails with NSERROR_BAD_URL if something invalid/garbage is fed in. Unfortunately this is causing the box creation to abort, rather than NULLing the link ref and continuing with the bad URL removed. |
|
Chris Young (developer) 2014-06-09 14:32 |
On further investigation, box_extract_link isn't handling NSERROR_BAD_URL, and nsurl_join is translating the NSERROR_BAD_URL to NSERROR_NOMEM, so it wouldn't see it anyway. |
|
Vincent Sanders (administrator) 2014-06-09 20:19 |
I have made nsurl_join cope with the host part of a url not being valid IDNA by falling back to the old method of simply using the broken hostname as is (same behaviour on chrome and firefox) Can people check and see if this fixes the issue for them |
|
Vincent Sanders (administrator) 2014-06-10 17:21 |
Made nsurl_join cope with IDNA being unable to parse an (invalid) hostname. This prevents errors being reported to the box tree generation as box_extract_link cannot cope at all. |
|
Vincent Sanders (administrator) 2015-03-10 11:05 |
Confirmed fixed in 3.2 release |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-06-09 11:03 | kinnison | New Issue | |
| 2014-06-09 11:03 | kinnison | Status | new => assigned |
| 2014-06-09 11:03 | kinnison | Assigned To | => Chris Young |
| 2014-06-09 12:31 | Vincent Sanders | Note Added: 0000372 | |
| 2014-06-09 12:31 | Vincent Sanders | Status | assigned => confirmed |
| 2014-06-09 13:37 | Vincent Sanders | File Added: Ashworth.html | |
| 2014-06-09 13:37 | Vincent Sanders | File Added: Barker.html | |
| 2014-06-09 13:55 | Chris Young | Note Added: 0000373 | |
| 2014-06-09 14:32 | Chris Young | Note Added: 0000374 | |
| 2014-06-09 20:19 | Vincent Sanders | Fixed in CI build # | => 1962 |
| 2014-06-09 20:19 | Vincent Sanders | Note Added: 0000375 | |
| 2014-06-10 17:21 | Vincent Sanders | Note Added: 0000376 | |
| 2014-06-10 17:21 | Vincent Sanders | Status | confirmed => resolved |
| 2014-06-10 17:21 | Vincent Sanders | Resolution | open => fixed |
| 2014-06-10 17:21 | Vincent Sanders | Fixed in Version | => 3.2 |
| 2015-03-10 11:05 | Vincent Sanders | Note Added: 0000707 | |
| 2015-03-10 11:05 | Vincent Sanders | Status | resolved => closed |
| Issue History |