2019-12-07 00:10 UTC

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002140NetSurfLayoutpublic2015-03-10 11:05
ReporterDaniel Silverstone 
Assigned ToChris Young 
SeveritycrashReproducibilityhave not tried 
StatusclosedResolutionfixed 
PlatformRISC OSOS?OS Version?
Product Version3.1 
Target Version3.2Fixed in Version3.2 
Summary0002140: Poor/invalid URLs can cause the layout engine to stop after IDNA code merge
DescriptionAs summary
Steps To ReproduceUnknown as yet, Bob Latham's intranet triggers this a lot. Perhaps a test case can be constructed.
Additional InformationSome people have shown failures of this ilk with unprocessed SSI in links. We may be able to use that to track down the issue.
TagsNo tags attached.
Fixed in CI build #1962
Reported in CI build #1959
URL of problem page
Attached Files

-Relationships
+Relationships

-Notes
Vincent Sanders

~0000372

Vincent Sanders (administrator)

This appears to be because the dom to box conversion fails when broken urls are processed instead of our previous behaviour of swallowing the garbage wholesale
Chris Young

~0000373

Chris Young (developer)

nsurl_create now fails with NSERROR_BAD_URL if something invalid/garbage is fed in. Unfortunately this is causing the box creation to abort, rather than NULLing the link ref and continuing with the bad URL removed.
Chris Young

~0000374

Chris Young (developer)

On further investigation, box_extract_link isn't handling NSERROR_BAD_URL, and nsurl_join is translating the NSERROR_BAD_URL to NSERROR_NOMEM, so it wouldn't see it anyway.
Vincent Sanders

~0000375

Vincent Sanders (administrator)

I have made nsurl_join cope with the host part of a url not being valid IDNA by falling back to the old method of simply using the broken hostname as is (same behaviour on chrome and firefox)

Can people check and see if this fixes the issue for them
Vincent Sanders

~0000376

Vincent Sanders (administrator)

Made nsurl_join cope with IDNA being unable to parse an (invalid) hostname. This prevents errors being reported to the box tree generation as box_extract_link cannot cope at all.
Vincent Sanders

~0000707

Vincent Sanders (administrator)

Confirmed fixed in 3.2 release
+Notes

-Issue History
Date Modified Username Field Change
2014-06-09 11:03 Daniel Silverstone New Issue
2014-06-09 11:03 Daniel Silverstone Status new => assigned
2014-06-09 11:03 Daniel Silverstone Assigned To => Chris Young
2014-06-09 12:31 Vincent Sanders Note Added: 0000372
2014-06-09 12:31 Vincent Sanders Status assigned => confirmed
2014-06-09 13:37 Vincent Sanders File Added: Ashworth.html
2014-06-09 13:37 Vincent Sanders File Added: Barker.html
2014-06-09 13:55 Chris Young Note Added: 0000373
2014-06-09 14:32 Chris Young Note Added: 0000374
2014-06-09 20:19 Vincent Sanders Fixed in CI build # => 1962
2014-06-09 20:19 Vincent Sanders Note Added: 0000375
2014-06-10 17:21 Vincent Sanders Note Added: 0000376
2014-06-10 17:21 Vincent Sanders Status confirmed => resolved
2014-06-10 17:21 Vincent Sanders Resolution open => fixed
2014-06-10 17:21 Vincent Sanders Fixed in Version => 3.2
2015-03-10 11:05 Vincent Sanders Note Added: 0000707
2015-03-10 11:05 Vincent Sanders Status resolved => closed
+Issue History