| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 0002129 | NetSurf | Amiga-specific | public | 2014-05-22 18:31 | 2014-06-04 17:19 | ||||||||
| Reporter | Chris Young | ||||||||||||
| Assigned To | Michael Drake | ||||||||||||
| Severity | crash | Reproducibility | always | ||||||||||
| Status | confirmed | Resolution | open | ||||||||||
| Platform | Amiga | OS | AmigaOS | OS Version | 4.1 | ||||||||
| Product Version | 3.2 | ||||||||||||
| Target Version | Fixed in Version | ||||||||||||
| Summary | 0002129: Assert when selecting plain text | ||||||||||||
| Description | I got the following assert when selecting some text in a plain text file: assertion failed end<=text->utf8_data_size in render/textplain line 1218 | ||||||||||||
| Additional Information | I've had similar problems with text selection in the past, which only seems to occur on plain text files, not HTML. | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Fixed in CI build # | |||||||||||||
| Reported in CI build # | 1900 | ||||||||||||
| URL of problem page | |||||||||||||
| Attached Files |
| ||||||||||||
 Relationships |
|
 Relationships |
| Notes |
|
Vincent Sanders (administrator) 2014-05-29 10:45 |
I had an extensive look at reproducing this and failed, though I did find and fix another bug (0002134) concerning line widths in text plain display. This assert is actually caused because the plain text content handler "highlight the selected area" is being called with the end of the selected text beyond the number of characters in the buffer. I have not yet been able to trace execution all the way back through to your front-end but I cannot reproduce the issue on gtk or framebuffer so I imagine this is something to do with disagreements over what index value the buffer ends at. Could you add some debugging in render/textplain.c:1233 in textplain_coords_from_range() showing what the end value and text->utf8_data_size are when you reproduce the issue? |
Chris Young (developer) 2014-05-29 22:30 |
In that file, highlighting from "box drawing alignment tests" to the end of the file causes the same assert. |
|
Vincent Sanders (administrator) 2014-05-29 22:33 |
ok, but it would be useful to know what the end value and text->utf8_data_size are as then we can tell it it is a simple off by 1 or if we are selecting completely out of bounds |
|
Chris Young (developer) 2014-05-30 18:01 |
That was more a note for me, although once I'd added the debug it refused to crash in the same place. I managed to get it to crash in a different file though: end=1461256365, utf8_data_size=80112 The line above had end=165, so it looks like somehow end has got uninitialised? |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-05-22 18:31 | Chris Young | New Issue | |
| 2014-05-24 20:19 | Vincent Sanders | Assigned To | => Michael Drake |
| 2014-05-24 20:19 | Vincent Sanders | Reproducibility | have not tried => always |
| 2014-05-24 20:19 | Vincent Sanders | Status | new => confirmed |
| 2014-05-24 20:19 | Vincent Sanders | Description Updated | View Revisions |
| 2014-05-29 10:45 | Vincent Sanders | Note Added: 0000354 | |
| 2014-05-29 10:45 | Vincent Sanders | Assigned To | Michael Drake => Chris Young |
| 2014-05-29 10:45 | Vincent Sanders | Category | Layout => Amiga-specific |
| 2014-05-29 22:30 | Chris Young | Note Added: 0000360 | |
| 2014-05-29 22:33 | Vincent Sanders | Note Added: 0000361 | |
| 2014-05-30 18:01 | Chris Young | Note Added: 0000362 | |
| 2014-06-04 17:19 | Chris Young | Assigned To | Chris Young => Michael Drake |
| 2014-06-04 17:19 | Chris Young | Status | confirmed => assigned |
| 2014-06-04 17:19 | Chris Young | Status | assigned => confirmed |
| 2014-06-04 17:19 | Chris Young | Description Updated | View Revisions |
| Issue History |