2019-12-07 00:24 UTC

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002129NetSurfAmiga-specificpublic2014-06-04 17:19
ReporterChris Young 
Assigned ToMichael Drake 
SeveritycrashReproducibilityalways 
StatusconfirmedResolutionopen 
PlatformAmigaOSAmigaOSOS Version4.1
Product Version3.2 
Target VersionFixed in Version 
Summary0002129: Assert when selecting plain text
DescriptionI got the following assert when selecting some text in a plain text file:
assertion failed end<=text->utf8_data_size in render/textplain line 1218
Additional InformationI've had similar problems with text selection in the past, which only seems to occur on plain text files, not HTML.
TagsNo tags attached.
Fixed in CI build #
Reported in CI build #1900
URL of problem page
Attached Files

-Relationships
+Relationships

-Notes
Vincent Sanders

~0000354

Vincent Sanders (administrator)

I had an extensive look at reproducing this and failed, though I did find and fix another bug (0002134) concerning line widths in text plain display.

This assert is actually caused because the plain text content handler "highlight the selected area" is being called with the end of the selected text beyond the number of characters in the buffer.

I have not yet been able to trace execution all the way back through to your front-end but I cannot reproduce the issue on gtk or framebuffer so I imagine this is something to do with disagreements over what index value the buffer ends at.

Could you add some debugging in render/textplain.c:1233 in textplain_coords_from_range() showing what the end value and text->utf8_data_size are when you reproduce the issue?

Chris Young

~0000360

Chris Young (developer)

In that file, highlighting from "box drawing alignment tests" to the end of the file causes the same assert.
Vincent Sanders

~0000361

Vincent Sanders (administrator)

ok, but it would be useful to know what the end value and text->utf8_data_size are as then we can tell it it is a simple off by 1 or if we are selecting completely out of bounds
Chris Young

~0000362

Chris Young (developer)

That was more a note for me, although once I'd added the debug it refused to crash in the same place.

I managed to get it to crash in a different file though:
end=1461256365, utf8_data_size=80112

The line above had end=165, so it looks like somehow end has got uninitialised?
+Notes

-Issue History
Date Modified Username Field Change
2014-05-22 18:31 Chris Young New Issue
2014-05-24 20:19 Vincent Sanders Assigned To => Michael Drake
2014-05-24 20:19 Vincent Sanders Reproducibility have not tried => always
2014-05-24 20:19 Vincent Sanders Status new => confirmed
2014-05-24 20:19 Vincent Sanders Description Updated View Revisions
2014-05-29 10:45 Vincent Sanders Note Added: 0000354
2014-05-29 10:45 Vincent Sanders Assigned To Michael Drake => Chris Young
2014-05-29 10:45 Vincent Sanders Category Layout => Amiga-specific
2014-05-29 22:30 Chris Young Note Added: 0000360
2014-05-29 22:33 Vincent Sanders Note Added: 0000361
2014-05-30 18:01 Chris Young Note Added: 0000362
2014-06-04 17:19 Chris Young Assigned To Chris Young => Michael Drake
2014-06-04 17:19 Chris Young Status confirmed => assigned
2014-06-04 17:19 Chris Young Status assigned => confirmed
2014-06-04 17:19 Chris Young Description Updated View Revisions
+Issue History