2024-11-24 16:31 UTC
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002242LibNSFB[All Projects] Generalpublic2014-12-14 09:392015-01-16 09:05
ReporterEdward Betts 
Assigned ToVincent Sanders 
PrioritynormalSeverityminorReproducibilityalways
StatusacknowledgedResolutionopen 
PlatformLinux x86_64OSDebianOS Versionunstable
Summary0002242: every other keystroke lost when using VNC
DescriptionEvery other keystroke is lost when using netsurf via VNC.

I've attached a patch which fixes the problem.
Steps To ReproduceI start netsurf-fb like this: "netsurf-fb -f vnc", I've tried connecting
with three VNC viewers: TightVNC, vinagre and novnc. In all three cases
netsurf is only responding to half of my keystrokes, if I type this into
any text box: 12345678, then the text that appears is 1357.
Additional InformationAlso reported this in the Debian BTS: https://bugs.debian.org/765880
TagsNo tags attached.
Fixed in CI build #
Reported in CI build #
Attached Files
  • ? file icon libnsfb-patch (578 bytes) 2014-12-14 09:39 - 
    --- libnsfb/src/surface/vnc.c.orig  2014-10-21 14:03:31.740181270 +0000
+++ libnsfb/src/surface/vnc.c   2014-10-21 15:20:02.630965646 +0000
@@ -480,6 +480,7 @@
     rfbScreenInfoPtr vncscreen = nsfb->surface_priv;
 
     rfbMarkRectAsModified(vncscreen, box->x0, box->y0, box->x1, box->y1);
+    rfbProcessEvents(vncscreen, 1);
 
     return 0;
 }
@@ -499,7 +500,7 @@
    event->value.controlcode = NSFB_CONTROL_TIMEOUT;
 
    ret = rfbProcessEvents(vncscreen, timeout * 1000);
-   if (ret == 0) {
+   if (ret == 0 || ret == -1) {
        /* valid event */
        return true;
    ? file icon libnsfb-patch (578 bytes) 2014-12-14 09:39 +

-Relationships
+Relationships

-Notes
There are no notes attached to this issue.
+Notes

-Issue History
Date Modified Username Field Change
2014-12-14 09:39 Edward Betts New Issue
2014-12-14 09:39 Edward Betts File Added: libnsfb-patch
2015-01-16 09:05 Vincent Sanders Assigned To => Vincent Sanders
2015-01-16 09:05 Vincent Sanders Status new => acknowledged
+Issue History