View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0002580 | NetSurf | GTK-specific | public | 2017-12-06 15:39 | 2018-08-29 15:04 | ||||
Reporter | Felix S. | ||||||||
Assigned To | |||||||||
Severity | minor | Reproducibility | always | ||||||
Status | closed | Resolution | fixed | ||||||
Product Version | 3.7 | ||||||||
Target Version | 3.8 | Fixed in Version | 3.8 | ||||||
Summary | 0002580: Botched pixel format conversion corrupts librsvg-rendered images | ||||||||
Description | SVG images rendered by NetSurf with the librsvg backend appear split into two parts, at one third of the image width. Both parts are wrongly coloured. The reason for this is a mistake in the image rendering code, specifically the routine which converts the rendered output into the pixel format used internally by NetSurf. | ||||||||
Steps To Reproduce | 0. Compile NetSurf with the librsvg backend enabled. 1. Open a random page with an SVG image embedded. 2. Observe the rendering. | ||||||||
Additional Information | Attached patch fixes the issue. The fixed code uses a uint8_t[4]/uint32_t union in order to avoid relying on target endianness (cairo's pixel format uses native 32-bit integers, NetSurf's uses a fixed order of 8-bit channels) | ||||||||
Tags | No tags attached. | ||||||||
Fixed in CI build # | 4289 | ||||||||
Reported in CI build # | |||||||||
URL of problem page | https://upload.wikimedia.org/wikipedia/commons/2/24/Euler_and_Venn_diagrams.svg | ||||||||
Attached Files |
|
Notes | |
John-Mark Bell (administrator) 2018-01-20 15:34 |
Thanks for the report. This is now fixed. |
Vincent Sanders (administrator) 2018-08-29 15:04 |
Thank you for your report, this has been resolved in the 3.8 release |
Issue History | |||
Date Modified | Username | Field | Change |
---|---|---|---|
2017-12-06 15:39 | Felix S. | New Issue | |
2017-12-06 15:39 | Felix S. | File Added: netsurf-rsvg.patch | |
2018-01-20 15:34 | John-Mark Bell | Note Added: 0001706 | |
2018-01-20 15:35 | John-Mark Bell | Product Version | => 3.7 |
2018-01-20 15:35 | John-Mark Bell | Fixed in Version | => 3.8 |
2018-01-20 15:35 | John-Mark Bell | Target Version | => 3.8 |
2018-01-20 15:35 | John-Mark Bell | Steps to Reproduce Updated | View Revisions |
2018-01-20 15:35 | John-Mark Bell | Fixed in CI build # | => 4289 |
2018-01-20 15:35 | John-Mark Bell | Status | new => resolved |
2018-01-20 15:35 | John-Mark Bell | Resolution | open => fixed |
2018-08-29 15:04 | Vincent Sanders | Status | resolved => closed |
2018-08-29 15:04 | Vincent Sanders | Note Added: 0001841 |