MantisBT - LibWapcaplet
View Issue Details
0002887LibWapcaplet[All Projects] Generalpublic2025-01-09 08:152025-01-09 15:03
Reporterأحمد المحمودي 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
PlatformOSLinuxOS Version
Fixed in CI build #
Reported in CI build #
Summary0002887: make check fails: fail_unless has too many arguments for format
Descriptionmake test for libwapcaplet fails with the following errors, when compiles with -Werror=format-extra-args:

        make -j2 test V=1 PREFIX=/usr COMPONENT_TYPE=lib-shared
make[2]: Entering directory '/builds/aelmahmoudy/libwapcaplet/debian/output/source_dir'
 COMPILE: test/testmain.c
 COMPILE: test/basictests.c
In file included from test/basictests.c:9:
test/basictests.c: In function 'test_lwc_intern_string_ok_fn':
test/basictests.c:119:21: error: too many arguments for format [-Werror=format-extra-args]
  119 | "Unable to intern a simple string");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:121:21: error: too many arguments for format [-Werror=format-extra-args]
  121 | "Returned OK but str was still NULL");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_intern_string_twice_ok_fn':
test/basictests.c:129:21: error: too many arguments for format [-Werror=format-extra-args]
  129 | "Unable to intern a simple string");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:131:21: error: too many arguments for format [-Werror=format-extra-args]
  131 | "Returned OK but str was still NULL");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:133:21: error: too many arguments for format [-Werror=format-extra-args]
  133 | "Unable to intern a simple string");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:135:21: error: too many arguments for format [-Werror=format-extra-args]
  135 | "Returned OK but str was still NULL");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_intern_string_twice_same_ok_fn':
test/basictests.c:143:21: error: too many arguments for format [-Werror=format-extra-args]
  143 | "Unable to intern a simple string");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:145:21: error: too many arguments for format [-Werror=format-extra-args]
  145 | "Returned OK but str was still NULL");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:147:21: error: too many arguments for format [-Werror=format-extra-args]
  147 | "Unable to intern a simple string");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:149:21: error: too many arguments for format [-Werror=format-extra-args]
  149 | "Returned OK but str was still NULL");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'with_filled_context_setup':
test/basictests.c:161:21: error: too many arguments for format [-Werror=format-extra-args]
  161 | "Unable to intern 'one'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:163:21: error: too many arguments for format [-Werror=format-extra-args]
  163 | "Unable to intern 'two'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:165:21: error: too many arguments for format [-Werror=format-extra-args]
  165 | "Unable to intern 'three'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:167:21: error: too many arguments for format [-Werror=format-extra-args]
  167 | "Unable to intern 'YAY'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:169:47: error: too many arguments for format [-Werror=format-extra-args]
  169 | fail_unless(intern_one != intern_two, "'one' == 'two'");
      | ^~~~~~~~~~~~~~~~
test/basictests.c:170:49: error: too many arguments for format [-Werror=format-extra-args]
  170 | fail_unless(intern_one != intern_three, "'one' == 'three'");
      | ^~~~~~~~~~~~~~~~~~
test/basictests.c:171:49: error: too many arguments for format [-Werror=format-extra-args]
  171 | fail_unless(intern_two != intern_three, "'two' == 'three'");
      | ^~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_interning_works_fn':
test/basictests.c:189:21: error: too many arguments for format [-Werror=format-extra-args]
  189 | "Unable to re-intern 'one'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:192:21: error: too many arguments for format [-Werror=format-extra-args]
  192 | "Internalising of the string failed");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_intern_substring_fn':
test/basictests.c:201:21: error: too many arguments for format [-Werror=format-extra-args]
  201 | "Unable to intern 'hre'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:204:21: error: too many arguments for format [-Werror=format-extra-args]
  204 | "Unable to re-intern 'hre' by substring");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:206:21: error: too many arguments for format [-Werror=format-extra-args]
  206 | "'hre' != 'hre' -- wow!");
      | ^~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_intern_substring_bad_offset_fn':
test/basictests.c:215:21: error: too many arguments for format [-Werror=format-extra-args]
  215 | "Able to intern substring starting out of range");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_intern_substring_bad_size_fn':
test/basictests.c:224:21: error: too many arguments for format [-Werror=format-extra-args]
  224 | "Able to intern substring ending out of range");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_string_ref_ok_fn':
test/basictests.c:231:21: error: too many arguments for format [-Werror=format-extra-args]
  231 | "Oddly, reffing a string didn't return it");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_string_isequal_ok_fn':
test/basictests.c:253:21: error: too many arguments for format [-Werror=format-extra-args]
  253 | "Failure comparing 'one' and 'two'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:255:21: error: too many arguments for format [-Werror=format-extra-args]
  255 | "'one' == 'two' ?!");
      | ^~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_string_caseless_isequal_ok1_fn':
test/basictests.c:265:21: error: too many arguments for format [-Werror=format-extra-args]
  265 | "Failure interning 'ONE'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:269:21: error: too many arguments for format [-Werror=format-extra-args]
  269 | "'one' == 'ONE' ?!");
      | ^~~~~~~~~~~~~~~~~~~
test/basictests.c:272:21: error: too many arguments for format [-Werror=format-extra-args]
  272 | "Failure comparing 'one' and 'ONE' caselessly");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:274:21: error: too many arguments for format [-Werror=format-extra-args]
  274 | "'one' !~= 'ONE' ?!");
      | ^~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_string_caseless_isequal_ok2_fn':
test/basictests.c:284:21: error: too many arguments for format [-Werror=format-extra-args]
  284 | "Failure interning 'yay'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:288:21: error: too many arguments for format [-Werror=format-extra-args]
  288 | "'yay' == 'YAY' ?!");
      | ^~~~~~~~~~~~~~~~~~~
test/basictests.c:291:21: error: too many arguments for format [-Werror=format-extra-args]
  291 | "Failure comparing 'yay' and 'YAY' caselessly");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:293:21: error: too many arguments for format [-Werror=format-extra-args]
  293 | "'yay' !~= 'YAY' ?!");
      | ^~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_string_caseless_isequal_bad_fn':
test/basictests.c:302:21: error: too many arguments for format [-Werror=format-extra-args]
  302 | "Failure comparing 'YAY' and 'one' caselessly");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:304:21: error: too many arguments for format [-Werror=format-extra-args]
  304 | "'YAY' ~= 'one' ?!");
      | ^~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_extract_data_ok_fn':
test/basictests.c:313:21: error: too many arguments for format [-Werror=format-extra-args]
  313 | "Extracting data ptr etc failed");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_string_is_nul_terminated_fn':
test/basictests.c:328:21: error: too many arguments for format [-Werror=format-extra-args]
  328 | "Failure interning 'ONE'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:331:21: error: too many arguments for format [-Werror=format-extra-args]
  331 | "Interned string isn't NUL terminated");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_substring_is_nul_terminated_fn':
test/basictests.c:341:21: error: too many arguments for format [-Werror=format-extra-args]
  341 | "Failure interning 'ONE'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:344:21: error: too many arguments for format [-Werror=format-extra-args]
  344 | "Failure interning substring 'O'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:347:21: error: too many arguments for format [-Werror=format-extra-args]
  347 | "Interned substring isn't NUL terminated");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_string_tolower_ok1_fn':
test/basictests.c:358:21: error: too many arguments for format [-Werror=format-extra-args]
  358 | "Failure interning 'ONE'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:361:38: error: too many arguments for format [-Werror=format-extra-args]
  361 | fail_unless(result == false, "'one' == 'ONE' ?!");
      | ^~~~~~~~~~~~~~~~~~~
test/basictests.c:363:37: error: too many arguments for format [-Werror=format-extra-args]
  363 | fail_unless(result == true, "'one' != 'one' ?!");
      | ^~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_string_tolower_ok2_fn':
test/basictests.c:374:21: error: too many arguments for format [-Werror=format-extra-args]
  374 | "Failure interning 'ONE'");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:377:37: error: too many arguments for format [-Werror=format-extra-args]
  377 | fail_unless(result == true, "'one' != 'ONE' (caseless) ?!");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/basictests.c:380:38: error: too many arguments for format [-Werror=format-extra-args]
  380 | fail_unless(result == false, "'one' == 'ONE' ?!");
      | ^~~~~~~~~~~~~~~~~~~
test/basictests.c:382:37: error: too many arguments for format [-Werror=format-extra-args]
  382 | fail_unless(result == true, "'one' != 'one' ?!");
      | ^~~~~~~~~~~~~~~~~~~
test/basictests.c: In function 'test_lwc_string_iteration_fn':
test/basictests.c:398:35: error: too many arguments for format [-Werror=format-extra-args]
  398 | fail_unless(counter == 4, "Incorrect string count");
      | ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
TagsNo tags attached.
Attached Files

Notes
(0002468)
أحمد المحمودي   
2025-01-09 15:03   
It seems to be an issue with libcheck 1.15.2, see: https://github.com/libcheck/check/issues/293

Maybe it would be better to use one of the ck_assert* functions instead of the deprecated fail_unless function

Issue History
2025-01-09 08:15أحمد المحموديNew Issue
2025-01-09 15:03أحمد المحموديNote Added: 0002468