MantisBT - NetSurf
View Issue Details
0002779NetSurfDevelopmentpublic2020-06-18 22:172020-06-18 22:17
ReporterMichael Orlitzky 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
PlatformOSGentooOS Version
Product Version3.10 
Target VersionFixed in Version 
Fixed in CI build #
Reported in CI build #
URL of problem pagehttps://bugs.gentoo.org/show_bug.cgi?id=687378
Summary0002779: Test failures (bloom, hashtable) on Gentoo
DescriptionHi, I'm trying to clean up some old NetSurf bugs on Gentoo before shipping v3.10. One of our developers reported the following test failure in v3.8 that I'm still able to reproduce on v3.10:

RUN TEST: bloom
LD_LIBRARY_PATH=build/Linux-test/ build/Linux-test/bloom
Running suite(s): Bloom filter
50%: Checks: 4, Failures: 2, Errors: 0
test/bloom.c:56:S:Match:bloom_match_test:0: Assertion 'dictf != ((void *)0)' failed
test/bloom.c:56:S:False positive rate:bloom_falsepositive_test:0: Assertion 'dictf != ((void *)0)' failed
make: *** [test/Makefile:199: bloom_test] Error 1


After skipping the bloom tests, there's another failure for hashtable in v3.10 (not tested any earlier) that is reproducible for me:

RUN TEST: hashtable
LD_LIBRARY_PATH=build/Linux-test/ build/Linux-test/hashtable
Running suite(s): hash table filter
86%: Checks: 15, Failures: 2, Errors: 0
test/hashtable.c:102:S:small table dictionary:hashtable_dict_test:0: Assertion 'dictf != ((void *)0)' failed
test/hashtable.c:102:S:large table dictionary:hashtable_dict_test:0: Assertion 'dictf != ((void *)0)' failed
make: *** [test/Makefile:204: hashtable_test] Error 1


Note that I also see what *look like* failures for nsurl, but they don't seem to halt the test suite:

RUN TEST: nsurl
LD_LIBRARY_PATH=build/Linux-test/ build/Linux-test/nsurl
Running suite(s): nsurl
nsurl: utils/nsurl/parse.c:1274: nsurl_create: Assertion `url_s != NULL' failed.
nsurl: utils/nsurl/nsurl.c:75: nsurl_ref: Assertion `url != NULL' failed.
nsurl: utils/nsurl/nsurl.c:86: nsurl_unref: Assertion `url != NULL' failed.
nsurl: utils/nsurl/nsurl.c:105: nsurl_compare: Assertion `url1 != NULL' failed.
nsurl: utils/nsurl/nsurl.c:106: nsurl_compare: Assertion `url2 != NULL' failed.
...
etc.


Let me know if you have any ideas on how to solve these. I'm available for testing, and our Gentoo bug (see $URL) contains plenty of information from the original reporter (who is also very helpful).
Steps To ReproduceSomething like,

  root # ACCEPT_KEYWORDS="~amd64" FEATURES=test USE=test emerge -v1 netsurf

does the trick for me, but at the moment it will install v3.9. I will probably patch out the failing tests before adding 3.10 as we don't want end users reproducing test failures =)
TagsNo tags attached.
Attached Files

There are no notes attached to this issue.

Issue History
2020-06-18 22:17Michael OrlitzkyNew Issue