MantisBT - NetSurf
View Issue Details
0002690NetSurfLayoutpublic2019-08-06 08:212019-08-06 09:14
ReporterMichael Drake 
Assigned To 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusacknowledgedResolutionopen 
PlatformAnyOSOS Version
Product Version 
Target Version3.10Fixed in Version 
Fixed in CI build #
Reported in CI build #
URL of problem pagehttps://www.netsons.com/
Summary0002690: Animated GIF causes box_coords to explode
Descriptionbox_coords walks up the box tree to find the absolute position of the box.

If we hit a float box, we expect to find a box with it's float_children set.

If not, the box tree is broken.

Daniel observed this happening on the 500 sites test run.

The problem is not easily reproducible.
Steps To ReproduceVisit https://www.netsons.com/

Although, when I load it, I don't even get the animated GIF throbbers that Daniel gets when he loads it.
TagsNo tags attached.
Attached Files

Notes
(0002066)
Michael Drake   
2019-08-06 08:23   
This change may or may not help:

http://source.netsurf-browser.org/netsurf.git/commit/?id=be23d522db03f412bc9a855aac7598419336d4f1

Either way, it's generally more optimal.
(0002067)
Michael Drake   
2019-08-06 08:26   
Note:

Neither float_children or float_container are assigned until layout.

However, it doesn't make sense to call box_coords on something before layout has happened.
(0002068)
Michael Drake   
2019-08-06 08:27   
Note:

We don't set float_children or float_container until layout because layout is the first pass over the box tree that works out which boxes will establish a new block formatting context.
(0002069)
Michael Drake   
2019-08-06 08:43   
Potentially fixed by:

http://source.netsurf-browser.org/netsurf.git/commit/?id=5e45c4498c0a8a24330864b3d4c68ffe891ce15e

Issue History
2019-08-06 08:21Michael DrakeNew Issue
2019-08-06 08:23Michael DrakeNote Added: 0002066
2019-08-06 08:26Michael DrakeNote Added: 0002067
2019-08-06 08:27Michael DrakeNote Added: 0002068
2019-08-06 08:43Michael DrakeNote Added: 0002069
2019-08-06 09:14Michael DrakeStatusnew => acknowledged