MantisBT - NetSurf
View Issue Details
0002661NetSurfDevelopmentpublic2019-06-02 13:172020-05-27 08:22
Reporterbrabo 
Assigned To 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformGTKOSDebianOS VersionBuster
Product Version3.8 
Target Version3.10Fixed in Version3.10 
Fixed in CI build #
Reported in CI build #4652
URL of problem pagen/a
Summary0002661: proposing comment correction and small simplification of code
Descriptionin gtk/fetch.c and monkey/filetype.c there was a small comment error.
in both twice a while loop also checked explicitly for "\n" after ascii_is_space already did so.
proposing a patch for each.
Steps To Reproducen/a
Additional Information2nd patch in my first note to this issue.
TagsNo tags attached.
Attached Filespatch 0001-gtk-fetch.c-monkey-filetype.c-small-comment-correcti.patch (1,244) 2019-06-02 13:17
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=589&type=bug
patch 0001-gtk-fetch.c-monkey-filetype.c-ascii_is_space-already.patch (1,975) 2019-06-02 13:18
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=590&type=bug

Notes
(0001930)
brabo   
2019-06-02 13:18   
2nd proposed patch attached,
greets!
(0002037)
Michael Drake   
2019-08-01 09:47   
Thanks for the patches! Applied. :)
(0002256)
Vincent Sanders   
2020-05-27 08:22   
Thankyou for reporting this issue.
We believe this is fixed in the 3.10 release.
If this is not the case please feel free to reopen the issue with additional details.

Issue History
2019-06-02 13:17braboNew Issue
2019-06-02 13:17braboFile Added: 0001-gtk-fetch.c-monkey-filetype.c-small-comment-correcti.patch
2019-06-02 13:18braboFile Added: 0001-gtk-fetch.c-monkey-filetype.c-ascii_is_space-already.patch
2019-06-02 13:18braboNote Added: 0001930
2019-08-01 09:47Michael DrakeStatusnew => resolved
2019-08-01 09:47Michael DrakeResolutionopen => fixed
2019-08-01 09:47Michael DrakeFixed in Version => 3.10
2019-08-01 09:47Michael DrakeTarget Version => 3.10
2019-08-01 09:47Michael DrakeNote Added: 0002037
2020-05-27 08:22Vincent SandersStatusresolved => closed
2020-05-27 08:22Vincent SandersNote Added: 0002256