MantisBT - NetSurf
View Issue Details
0002647NetSurfRISC OS-specificpublic2019-05-13 14:192019-07-19 09:29
ReporterBrian Jordan 
Assigned ToDaniel Silverstone 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformRaspberry PiOSRISC OSOS Version5.23
Product Version 
Target Version3.9Fixed in Version3.9 
Fixed in CI build #4646
Reported in CI build #4640
URL of problem pagehttps://www.clubmans.org.uk
Summary0002647: Crash in #4640
DescriptionConsistent crash in #4640
Steps To ReproduceOpen https://www.clubmans.org.uk and select "Current season" button in left column
Additional InformationThis happens regularly
TagsNo tags attached.
Attached Files? Log (71,645) 2019-05-13 14:19
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=586&type=bug

Notes
(0001917)
Daniel Silverstone   
2019-05-19 10:46   
I can confirm this, and it looks like it's a case of the old Window compartment not closing down properly:

(1.020374) build/Linux-gtk/duktape/window.c:189 window_alloc_new_callback: Scheduled callback 0 for 5000 ms from now
(2.716481) content/handlers/javascript/duktape/dukky.c:611 js_newcompartment: Old compartment present, closing it down
(2.722730) content/handlers/javascript/duktape/dukky.c:615 js_newcompartment: Window hopefully released
(2.722994) content/handlers/javascript/duktape/dukky.c:619 js_newcompartment: New javascript/duktape compartment, win_priv=0x55bf7a143360, doc_priv=0x55bf7a4ad8e0

Note how the callback isn't cancelled during the closedown of the compartment.

I shall investigate
(0001919)
Daniel Silverstone   
2019-05-25 16:31   
This was an interesting problem where the JS compartment didn't close down properly when being replaced. The underlying issue (that the Window object doesn't get finalised) is still there, but from #4646 I have put a workaround in place which resolves this particular issue (an unexpected callback firing because the Window hadn't cleaned up)
(0002007)
Vincent Sanders   
2019-07-19 09:29   
we believe this issue has been resolved in NetSurf 3.9

Issue History
2019-05-13 14:19Brian JordanNew Issue
2019-05-13 14:19Brian JordanFile Added: Log
2019-05-19 10:46Daniel SilverstoneAssigned To => Daniel Silverstone
2019-05-19 10:46Daniel SilverstoneStatusnew => confirmed
2019-05-19 10:46Daniel SilverstoneNote Added: 0001917
2019-05-25 16:31Daniel SilverstoneStatusconfirmed => resolved
2019-05-25 16:31Daniel SilverstoneResolutionopen => fixed
2019-05-25 16:31Daniel SilverstoneFixed in Version => 3.9
2019-05-25 16:31Daniel SilverstoneTarget Version => 3.9
2019-05-25 16:31Daniel SilverstoneFixed in CI build # => 4646
2019-05-25 16:31Daniel SilverstoneNote Added: 0001919
2019-07-19 09:29Vincent SandersStatusresolved => closed
2019-07-19 09:29Vincent SandersNote Added: 0002007