MantisBT - LibParserUtils
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002620LibParserUtils[All Projects] Generalpublic2018-09-25 05:052020-02-21 10:09
ReporterJ. Peter Mugaas 
Assigned ToVincent Sanders 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusassignedResolutionopen 
Platformmingw-w64OSWindows 10OS Version10
Product Version0.2.1 
Target VersionFixed in Version 
Fixed in CI build #
Reported in CI build #
Summary0002620: 0.2.4 - test suite cscodec-utf16.c in Windows
DescriptionI tried to compile cscodec-utf16.c in Windows with an automated build process that I was writing. I found that cscodec-utf16.c had these references:

 #include <arpa/inet.h>
 #include <netinet/in.h>

Those are NOT valid for Windows. To use the htonl and ntohl functions, you must include winsock2 and then you have to link to the Ws2_32 library. Please verify this statement at: https://docs.microsoft.com/en-us/windows/desktop/api/winsock/nf-winsock-ntohl .

I have done this in a cmake script I was writing to build libparserutils in Windows that includes running your test executables with a good deal of success I am providing a patch to fix the issue. Please feel free to use it.
TagsNo tags attached.
Relationships
Attached Filespatch test-htonl-ntohl.patch (394) 2018-09-25 05:05
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=562&type=bug

There are no notes attached to this issue.

Issue History
Date ModifiedUsernameFieldChange
2018-09-25 05:05J. Peter MugaasNew Issue
2018-09-25 05:05J. Peter MugaasFile Added: test-htonl-ntohl.patch
2020-02-21 10:09Vincent SandersAssigned To => Vincent Sanders
2020-02-21 10:09Vincent SandersStatusnew => assigned