MantisBT - NetSurf
View Issue Details
0002607NetSurf[All Projects] Generalpublic2018-07-30 17:512018-08-29 14:59
ReporterChris Young 
Assigned To 
PrioritynormalSeverityblockReproducibilityalways
StatusclosedResolutionfixed 
PlatformAmigaOSAmigaOSOS Version4.1
Product Version3.8 
Target Version3.8Fixed in Version3.8 
Fixed in CI build #4403
Reported in CI build #4385
URL of problem pagehttps://forum.amiga.org/
Summary0002607: HTTP Basic authentication keeps re-prompting
DescriptionHTTP Basic authentication keeps re-prompting for username/password. I think it is asking for every protected element on the page rather than retrying the previously input details automatically.
Steps To Reproduce was testing with a protected forum, however that site is not going to be protected for much longer and I can't give out the details, so, hmm...
Additional InformationLog attached.
This log involves me typing in the correct user/pass once and then cancelling all subsequent requests.
TagsNo tags attached.
Attached Filesgz ns.log.gz (60,217) 2018-07-30 17:51
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=550&type=bug
log ns_aorg.log (337,407) 2018-08-11 21:31
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=553&type=bug
log ns_cisecure.log (104,666) 2018-08-11 21:31
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=554&type=bug

Notes
(0001792)
Vincent Sanders   
2018-07-31 10:11   
Initial review of the log suggests this may be a https with basic auth issue

we probably need to set up a test server and verify this
(0001794)
Vincent Sanders   
2018-08-09 14:23   
I set up

https://ci.netsurf-browser.org/secure/

user:passwords are:

netsurf:netsurf
blank:

but netsurf works fine with the gtk frontend. Can you try with your frontend please?
(0001795)
Michael Drake   
2018-08-09 16:53   
Unrelated: I saw a pile of fetch_curl_poll logging in the log, which shouldn't have been enabled, so I've turned that off.

Probably unrelated: I see lots of lines like:

content/handlers/html/html.c:695 dom_default_action_DOMNodeInserted_cb: javascript context: 0x0 (htmlc: 0x5695b330)

And I have no idea how that can happen.

Chris: Does the build include the duktape stuff (build time option)? Are you running with the runtime choices option for JavaScript enabled or disabled?
(0001796)
Michael Drake   
2018-08-09 17:20   
Chris, please try with my latest commit that adds some logging for 401 windows.
(0001800)
Artu Jarosik   
2018-08-11 12:21   
The same happens on Chrome/Windows 10 so it must be site issue.
(0001801)
Chris Young   
2018-08-11 21:35   
(Last edited: 2018-08-11 21:50)
1. ci.netsurf-browser.org secure site doesn't even prompt for a user/pass (ns_cisecure.log) (it doesn't prompt on Firefox either)

2. Duktape is included and enabled at runtime

3. New log with CI 4393 - ns_aorg.log (same thing, typed user/pass once, cancelled the many other requests)

For some reason Mantis doesn't appear to be sending me updates, so give me a prod if I don't respond.

(0001802)
Michael Drake   
2018-08-14 12:18   
One possibility was that the Amiga front end was passing a garbage realm to urldb_set_auth_details. I've fixed that on master.

Also, I've made tlsa/401 branch, which moves responsibility for dealing with urldb to the core. I'd be grateful to anyone who can test it.
(0001803)
Michael Drake   
2018-08-14 15:46   
We can use httpbin for testing basic auth with username and password. I've opened an issue about testing when username and password aren't both present. https://github.com/requests/httpbin/issues/502
(0001824)
Vincent Sanders   
2018-08-29 14:59   
Thank you for your report, this has been resolved in the 3.8 release

Issue History
2018-07-30 17:51Chris YoungNew Issue
2018-07-30 17:51Chris YoungFile Added: ns.log.gz
2018-07-31 10:11Vincent SandersNote Added: 0001792
2018-07-31 10:11Vincent SandersStatusnew => acknowledged
2018-07-31 10:11Vincent SandersAdditional Information Updatedbug_revision_view_page.php?rev_id=2051#r2051
2018-07-31 10:11Vincent SandersURL of problem page => https://forum.amiga.org/
2018-08-07 11:15Vincent SandersSeverityminor => block
2018-08-07 11:15Vincent SandersStatusacknowledged => confirmed
2018-08-09 14:23Vincent SandersNote Added: 0001794
2018-08-09 14:23Vincent SandersStatusconfirmed => feedback
2018-08-09 16:53Michael DrakeNote Added: 0001795
2018-08-09 17:20Michael DrakeNote Added: 0001796
2018-08-11 12:21Artu JarosikNote Added: 0001800
2018-08-11 21:31Chris YoungFile Added: ns_aorg.log
2018-08-11 21:32Chris YoungFile Added: ns_cisecure.log
2018-08-11 21:35Chris YoungNote Added: 0001801
2018-08-11 21:35Chris YoungStatusfeedback => new
2018-08-11 21:36Chris YoungNote Edited: 0001801bug_revision_view_page.php?bugnote_id=1801#r2053
2018-08-11 21:50Chris YoungNote Edited: 0001801bug_revision_view_page.php?bugnote_id=1801#r2054
2018-08-14 12:18Michael DrakeNote Added: 0001802
2018-08-14 15:46Michael DrakeNote Added: 0001803
2018-08-16 20:19Michael DrakeStatusnew => resolved
2018-08-16 20:19Michael DrakeResolutionopen => fixed
2018-08-16 20:19Michael DrakeFixed in Version => 3.8
2018-08-16 20:19Michael DrakeFixed in CI build # => 4403
2018-08-29 14:59Vincent SandersStatusresolved => closed
2018-08-29 14:59Vincent SandersNote Added: 0001824