MantisBT - NetSurf
View Issue Details
0002506NetSurfRISC OS-specificpublic2017-01-06 10:242017-10-16 23:39
ReporterMichael Drake 
Assigned ToDave Higton 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformRISC OSOSRISC OSOS VersionAny
Product Version3.7 
Target VersionFixed in Version3.7 
Fixed in CI build #3955
Reported in CI build #3928
URL of problem page
Summary0002506: RISC OS: Can't move hotlist, history, cookies windows partially off screen
DescriptionTreeview windows are constrained to stay entirely on screen.
Steps To ReproduceRight click NetSurf icon bar icon.

Drag hotlist window to screen edge.
TagsNo tags attached.
Attached Files

Notes
(0001483)
Dave Higton   
2017-01-09 22:21   
The "tree" window template definition, in common with all except one window, does not have the wimp_WINDOW_NO_BOUNDS flag set. It's curious that all other windows have this flag bit set in code rather than in the template, which seems wrong to me. Anyway, fixing the various tree view windows would require changes in more places than the templates AFAICS, so I propose to change the template definitions.

The tree view code needs to be replaced at some point anyway, so this can be regarded as a temporary fix.
(0001484)
Dave Higton   
2017-01-10 11:32   
After a re-think and some more information, I submitted patches to the four template definition files, to OR in the wimp_WINDOW_NO_BOUNDS flag bit. I submitted them via an email to the ns-dev mailing list.

The treeview code was updated in late December. Previously the flag bit must have been applied in code. The templates are the correct place to specify such fundamental window behaviour.
(0001664)
Vincent Sanders   
2017-10-16 23:39   
Thankyou for your report, this has been resolved in the 3.7 release

Issue History
2017-01-06 10:24Michael DrakeNew Issue
2017-01-09 22:21Dave HigtonNote Added: 0001483
2017-01-09 22:21Dave HigtonAssigned To => Dave Higton
2017-01-09 22:21Dave HigtonStatusnew => confirmed
2017-01-09 22:21Dave HigtonSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1911#r1911
2017-01-10 11:32Dave HigtonFixed in CI build # => 3955
2017-01-10 11:32Dave HigtonReported in CI build # => 3928
2017-01-10 11:32Dave HigtonNote Added: 0001484
2017-01-10 11:32Dave HigtonStatusconfirmed => resolved
2017-01-10 11:32Dave HigtonResolutionopen => fixed
2017-01-10 11:32Dave HigtonFixed in Version => 3.7
2017-04-23 10:20Vincent SandersProduct Version4.0 => 3.7
2017-04-23 10:20Vincent SandersSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1945#r1945
2017-10-16 23:39Vincent SandersStatusresolved => closed
2017-10-16 23:39Vincent SandersNote Added: 0001664