MantisBT - LibCSS | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0002432 | LibCSS | [All Projects] General | public | 2016-02-22 02:48 | 2016-03-07 13:36 |
| Reporter | Anthony J. Bentley | ||||
|---|---|---|---|---|---|
| Assigned To | |||||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | confirmed | Resolution | open | ||
| Platform | OS | OpenBSD | OS Version | ||
| Fixed in CI build # | |||||
| Reported in CI build # | |||||
| Summary | 0002432: libcss testsuite uses reserved identifiers | ||||
| Description | ISO C reserves identifiers beginning with __. The libcss test suite creates a function called __assert2, which conflicts with a function in OpenBSD's assert.h, resulting in a build failure before the tests can be run: echo " COMPILE: test/csdetect.c" COMPILE: test/csdetect.c cc -MMD -MP -D_BSD_SOURCE -D_DEFAULT_SOURCE -I/usr/ports/pobj/libcss-0.6.0/libcss-0.6.0/include/ -I/usr/ports/pobj/libcss-0.6.0/libcss-0.6.0/src -Wall -W -Wundef -Wpointer-arith -Wcast-align -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -Werror -O2 -pipe -g -I/include -I/usr/local/include -D_ALIGNED="__attribute__((aligned))" -DNDEBUG -std=c99 -I/usr/local/include -o build-amd64-unknown-openbsd5.9-amd64-unknown-openbsd5.9-release-lib-shared/test_csdetect.o -c test/csdetect.c In file included from test/csdetect.c:15: test/testutils.h:18: error: conflicting types for '__assert2' /usr/include/assert.h:66: error: previous declaration of '__assert2' was here test/testutils.h:22: error: conflicting types for '__assert2' /usr/include/assert.h:66: error: previous declaration of '__assert2' was here /usr/local/share/netsurf-buildsystem/makefiles/Makefile.top:614: recipe for target 'build-amd64-unknown-openbsd5.9-amd64-unknown-openbsd5.9-release-lib-shared/test_csdetect.o' failed gmake: *** [build-amd64-unknown-openbsd5.9-amd64-unknown-openbsd5.9-release-lib-shared/test_csdetect.o] Error 1 The attached patch renames the function, which allows the build to continue and all tests to pass. | ||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files |  libcss-test_testutils.diff (962) 2016-02-22 02:48https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=416&type=bug | ||||
| There are no notes attached to this issue. |
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
|---|---|---|---|---|---|
| 2016-02-22 02:48 | Anthony J. Bentley | New Issue | |||
| 2016-02-22 02:48 | Anthony J. Bentley | File Added: libcss-test_testutils.diff | |||
| 2016-03-07 13:36 | Vincent Sanders | Status | new => confirmed | ||