MantisBT - NetSurf |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0002415 | NetSurf | Javascript | public | 2016-01-27 17:55 | 2016-02-16 14:08 |
|
| Reporter | Michael Drake | |
|---|
| Assigned To | John-Mark Bell | |
|---|
| Priority | normal | Severity | crash | Reproducibility | always |
|---|
| Status | closed | Resolution | fixed | |
|---|
| Platform | Linux | OS | Linux | OS Version | Linux |
|---|
| Product Version | 3.4 | |
|---|
| Target Version | 3.4 | Fixed in Version | 3.4 | |
|---|
| Fixed in CI build # | 3333 |
|---|
| Reported in CI build # | 3315 |
|---|
| URL of problem page | test/js/dom-body-enumerate.html |
|---|
|
| Summary | 0002415: Crash on test/js/dom-body-enumerate.html |
|---|
| Description | We currently segfault on the test/js/dom-body-enumerate.html test.
In the body element binding we use an autogenerated getter for the text attribute:
getter HTMLBodyElement::text();
This becomes a call to libdom's dom_html_body_element_get_text(). The BODY element on the document has no TEXT attribute set. So libdom returns the NULL string with no error.
The generated binding does not handle NULL strings and explodes when it dereferences the NULL dom_string.
The IDL says:
[TreatNullAs=EmptyString] attribute DOMString text;
I am not sure if that means libdom should be changed to return an empty string, or if the generated binding should be changed to handle NULL strings. |
|---|
| Steps To Reproduce | ./nsgtk test/js/dom-body-enumerate.html |
|---|
| Tags | No tags attached. |
|---|
| Relationships | |
| Attached Files | |
|---|