MantisBT - NetSurf
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002343NetSurf[All Projects] Generalpublic2015-08-10 23:432016-02-16 14:07
ReporterHarriet Bazley 
Assigned ToDaniel Silverstone 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformARMOSRISC OSOS Version5.19
Product Version 
Target VersionFixed in Version3.4 
Fixed in CI build #
Reported in CI build #2875
URL of problem page
Summary0002343: Netsurf isn't saving JavaScript status
DescriptionAs of my most recent download (v2875) Netsurf no longer seems to be saving the JavaScript on/off state to its Choices file. Altering the state of the 'Hide advertisements icon, for example, alters the content of the file saved: selecting 'Disable JavaScript' only affects the current session and the status is not saved to disc on exit.

The effect is that Netsurf repeatedly defaults without warning to JavaScript-enabled status, causing pages to hang....
Steps To ReproduceOpen configuration window. Select Content->Content blocking->Disable JavaScript
Quit Netsurf.

Reload. Icon is no longer selected. Inspection of <Choices$Write>.WWW.NetSurf.Choices shows no configuration line has been written to file.
Additional InformationNetsurf v2875, RISC OS 5.21, ARMini.
TagsNo tags attached.
Relationships
Attached Files

Notes
(0000883)
Daniel Silverstone   
2015-08-11 11:16   
Yep, this is currently the behaviour we expect. We're testing a new JS implementation and part of this involves forcing it on all the time.

We'll turn it back to choices-controlled when we're back to feature parity. For now, you can simply turn JS off every time you load the browser instead.
(0000885)
Harriet Bazley   
2015-08-11 14:18   
This is a bit complicated for my mother, I'm afraid ("The browser isn't working!")

The safest thing to do is probably to revert to an earlier version for the moment.
(0000886)
Daniel Silverstone   
2015-08-11 14:33   
Aye, sorry, but CI releases are not meant for non-technical users anyway, since it's quite hard to get good bug reports out of them :-)

I hope to be in a position to disable the 'force-on' fairly soon, but it's a long slog back to feature parity with our JSAPI implementation.
(0000887)
Daniel Silverstone   
2015-08-11 15:15   
Oh, as an additional comment, I'd love some examples of pages which hang with JS on, so I can start to debug why :-)
(0000890)
Harriet Bazley   
2015-08-12 09:59   
This is the last one we encountered: https://www.fanfiction.net/topic/70706/22069226/13/#138517133
(0001021)
Dave Higton   
2015-11-02 22:45   
The URL cited by Harriet does not hang with JS on, in CI#3046. If it appeared to do so before, this is probably another manifestation of the slow regex interpreter that was fixed recently.
(0001022)
Harriet Bazley   
2015-11-03 00:26   
Yes, this is the same bug that was fixed for that site as 2364/2366.
(0001189)
Dave Higton   
2016-02-04 22:08   
This has been fixed as of quite a few versions ago, getting ready for another release.
(0001234)
Vincent Sanders   
2016-02-16 14:06   
Confirmed fixed in 3.4 release

Issue History
Date ModifiedUsernameFieldChange
2015-08-10 23:43Harriet BazleyNew Issue
2015-08-11 11:16Daniel SilverstoneNote Added: 0000883
2015-08-11 11:16Daniel SilverstoneAssigned To => Daniel Silverstone
2015-08-11 11:16Daniel SilverstoneStatusnew => confirmed
2015-08-11 11:16Daniel SilverstoneCategoryRISC OS-specific => General
2015-08-11 11:16Daniel SilverstoneDescription Updatedbug_revision_view_page.php?rev_id=1513#r1513
2015-08-11 11:16Daniel SilverstoneSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1515#r1515
2015-08-11 14:18Harriet BazleyNote Added: 0000885
2015-08-11 14:33Daniel SilverstoneNote Added: 0000886
2015-08-11 15:15Daniel SilverstoneNote Added: 0000887
2015-08-12 09:59Harriet BazleyNote Added: 0000890
2015-11-02 22:45Dave HigtonNote Added: 0001021
2015-11-02 22:45Dave HigtonNote Edited: 0001021bug_revision_view_page.php?bugnote_id=1021#r1656
2015-11-03 00:26Harriet BazleyNote Added: 0001022
2016-02-04 22:08Dave HigtonNote Added: 0001189
2016-02-04 22:08Dave HigtonStatusconfirmed => resolved
2016-02-04 22:08Dave HigtonResolutionopen => fixed
2016-02-04 22:08Dave HigtonDescription Updatedbug_revision_view_page.php?rev_id=1766#r1766
2016-02-04 22:08Dave HigtonSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1767#r1767
2016-02-16 14:06Vincent SandersNote Added: 0001234
2016-02-16 14:06Vincent SandersFixed in Version => 3.4
2016-02-16 14:06Vincent SandersDescription Updatedbug_revision_view_page.php?rev_id=1807#r1807
2016-02-16 14:06Vincent SandersSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1808#r1808
2016-02-16 14:07Vincent SandersStatusresolved => closed