MantisBT - NetSurf |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0002339 | NetSurf | RISC OS-specific | public | 2015-08-02 12:20 | 2016-02-16 14:13 |
|
| Reporter | Harriet Bazley | |
|---|
| Assigned To | Dave Higton | |
|---|
| Priority | normal | Severity | minor | Reproducibility | always |
|---|
| Status | closed | Resolution | fixed | |
|---|
| Platform | ARM | OS | RISC OS | OS Version | 5.19 |
|---|
| Product Version | 3.4 | |
|---|
| Target Version | | Fixed in Version | 3.4 | |
|---|
| Fixed in CI build # | 3251 |
|---|
| Reported in CI build # | 2817 |
|---|
| URL of problem page | https://en.wikipedia.org/wiki/Primogeniture |
|---|
|
| Summary | 0002339: F4 search can ignore case sensitivity settings |
|---|
| Description | When searching the text of a web page, selecting the 'case sensitive' option often seems to have no effect.
RISC OS 5.21 on ARMini |
|---|
| Steps To Reproduce | This doesn't always seem to happen. An example that I managed to use to trigger it was to visit https://en.wikipedia.org/wiki/Primogeniture, press F4 and type 'Fr' into the 'Find text' dialogue box. The first string found is the 'Fr' in "From Wikipedia, the free encyclopedia".
If I now select the 'Case sensitive' radio icon, the selected text jumps to the 'fr' in "free encyclopedia", which is clearly incorrect (this does not match 'Fr' in a case-sensitive match), and clicking on the 'Next' button then takes us to matches in "the free dictionary", "the higher nobility and free families alike" and many more before reaching the first true match in "France" (which is what I was looking for).
|
|---|
| Additional Information | If I select the 'Case sensitive' radio icon before typing any search string rather than as a subsequent modification to the search, I seem to get the expected results (in this test case at any rate).
This bug has been around through many versions - I first noticed it a long time ago but have only just pursued it to source. |
|---|
| Tags | No tags attached. |
|---|
| Relationships | |
| Attached Files |  index.htm (801) 2015-11-29 21:31
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=391&type=bug
 patch.txt (479) 2015-12-24 19:45
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=394&type=bug |
|---|
|
Notes |
|
|
|
|
We have no RISC OS maintainer so it is unlikely this will get addressed but i will leave it open for now. |
|
|
|
|
Last night I chased the flags through, and out of the RISC OS specific part. The flags are correctly passed to the search function. The search only appears to obey the case sensitivity flag's value that was set before a search string was typed in.
We need somebody else to look at another platform and see if it fails equally.
How does search work? Does it create a list of all matches, then simply step through the list? |
|
|
|
(0001027)
|
|
Dave Higton
|
2015-11-04 22:15
(Last edited: 2015-11-04 22:19) |
|
If the content of the search text box is changed in mid-search, two things happen:
1) The caret leaps back to the first occurrence.
2) The case sensitivity flag's value is now honoured.
I'm puzzled.
I downloaded the latest Windows CI version today at work, but I couldn't see a search box open, so I was unable to try it on a different platform.
I've uploaded a test file, index.html, which is a quick and easy source of data to search.
|
|
|
|
(0001124)
|
|
Dave Higton
|
2015-11-29 21:37
(Last edited: 2015-11-29 21:43) |
|
I've updated the test file index.html so that the content is on separate lines.
Using "Show all" is very illuminating - all the matching entries are highlighted, showing that the list of targets has been pre-calculated. Toggling case sensitivity doesn't change the highlighted entries, but editing the search text changes the list immediately.
I can't see, from the code, why the two operations produce a different result. One elementary difficulty is that they both call a function named "search", which is too generic a name to trawl the code for.
Is the search term cached, and does this result in the match list not being updated if the search term is the same when search is called next?
Edit: Yes, it does. I've made the toggle case sensitivity button call a dummy search for " " prior to calling the search for the real string. This causes the search list to be updated immediately the case sensitivity is toggled.
|
|
|
|
|
|
patch.txt is a patch that fixes it. |
|
|
|
|
|
Confirmed fixed in 3.4 release |
|
| Issue History |
|
| Date Modified | Username | Field | Change |
|---|
| 2015-08-02 12:20 | Harriet Bazley | New Issue | |
| 2015-08-24 14:11 | Vincent Sanders | Note Added: 0000937 | |
| 2015-08-24 14:11 | Vincent Sanders | Status | new => acknowledged |
| 2015-08-24 14:11 | Vincent Sanders | Product Version | => 3.4 |
| 2015-08-24 14:11 | Vincent Sanders | Description Updated | bug_revision_view_page.php?rev_id=1538#r1538 |
| 2015-08-24 14:11 | Vincent Sanders | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=1540#r1540 |
| 2015-08-24 14:11 | Vincent Sanders | Additional Information Updated | bug_revision_view_page.php?rev_id=1542#r1542 |
| 2015-11-04 14:42 | Dave Higton | Note Added: 0001024 | |
| 2015-11-04 22:15 | Dave Higton | Note Added: 0001027 | |
| 2015-11-04 22:15 | Dave Higton | File Added: index.htm | |
| 2015-11-04 22:18 | Dave Higton | Note Edited: 0001027 | bug_revision_view_page.php?bugnote_id=1027#r1664 |
| 2015-11-04 22:19 | Dave Higton | Note Edited: 0001027 | bug_revision_view_page.php?bugnote_id=1027#r1665 |
| 2015-11-04 22:20 | Dave Higton | Reproducibility | sometimes => always |
| 2015-11-04 22:20 | Dave Higton | Description Updated | bug_revision_view_page.php?rev_id=1666#r1666 |
| 2015-11-04 22:20 | Dave Higton | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=1667#r1667 |
| 2015-11-04 22:20 | Dave Higton | Additional Information Updated | bug_revision_view_page.php?rev_id=1668#r1668 |
| 2015-11-29 21:30 | Dave Higton | File Deleted: index.htm | |
| 2015-11-29 21:31 | Dave Higton | File Added: index.htm | |
| 2015-11-29 21:37 | Dave Higton | Note Added: 0001124 | |
| 2015-11-29 21:43 | Dave Higton | Note Edited: 0001124 | bug_revision_view_page.php?bugnote_id=1124#r1729 |
| 2015-12-24 19:45 | Dave Higton | Note Added: 0001130 | |
| 2015-12-24 19:45 | Dave Higton | File Added: patch.txt | |
| 2016-01-06 16:02 | Dave Higton | Fixed in CI build # | => 3251 |
| 2016-01-06 16:02 | Dave Higton | Assigned To | => Dave Higton |
| 2016-01-06 16:02 | Dave Higton | Status | acknowledged => resolved |
| 2016-01-06 16:02 | Dave Higton | Resolution | open => fixed |
| 2016-01-06 16:02 | Dave Higton | Fixed in Version | => 3.4 |
| 2016-02-16 14:12 | Vincent Sanders | Note Added: 0001248 | |
| 2016-02-16 14:12 | Vincent Sanders | Description Updated | bug_revision_view_page.php?rev_id=1809#r1809 |
| 2016-02-16 14:12 | Vincent Sanders | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=1810#r1810 |
| 2016-02-16 14:12 | Vincent Sanders | Additional Information Updated | bug_revision_view_page.php?rev_id=1811#r1811 |
| 2016-02-16 14:13 | Vincent Sanders | Status | resolved => closed |