MantisBT - NetSurf
View Issue Details
0002336NetSurfRISC OS-specificpublic2015-07-29 22:322016-02-16 14:45
ReporterSprow 
Assigned ToMichael Drake 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.3 
Target VersionFixed in Version3.4 
Fixed in CI build #3033
Reported in CI build #
URL of problem page
Summary0002336: Colours rendered incorrectly in 4k and 64k colour modes
DescriptionWhen choosing a 4k colour mode, or 64k colour mode, NetSurf's pages are rendered in the wrong colours (when Use OS/Use OS is selected in the 'Images' choices, as I suspect Tinct predates RISC OS Select getting 64k colour modes, and RISC OS 5 getting 4k + 64k colour modes).
Steps To ReproduceSwitch to a 4k or 64k colour mode.
Go to the default "about:welcome" page.
Additional InformationRisc PC, RISC OS 5.22.
TagsNo tags attached.
Attached Filespatch buffer.patch (4,059) 2015-08-13 18:56
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=313&type=bug

Notes
(0000882)
Sprow   
2015-07-29 22:36   
I've taken a quick look at the rendering code and have a reasonable idea of where the problem might be, but can't be 100% sure by inspection. I don't have any Linux system (nearest, cygwin in Windows), but wonder if there's a headless server somewhere with the environment already set up that I could just telnet/ssh into and type "make" having done local edits, then grab the executable via FTP to test. Rinse & repeat.
(0000884)
Rob Kendrick   
2015-08-11 11:26   
There is a guide on how to set up a virtual machine using VirtualBox (which is a free VM product for Windows and other platforms) on our wiki:

http://wiki.netsurf-browser.org/Documentation/BuildingForRISCOSQuickStart
(0000889)
Sprow   
2015-08-12 00:15   
Thanks Rob, that's a very useful page. I'd followed the "building NetSurf" link on the right of http://www.netsurf-browser.org/developers/ which led to http://source.netsurf-browser.org/netsurf.git/tree/Docs which seemed to be missing the instructions for RISC OS.

Have now installed VirtualBox and Debian 8 and produced a working !RunImage following those instructions, so it should be tractable to try out my fix now.

As an aside (this ticket is the wrong place) 'make TARGET=riscos package' resulted in a Messages file of 0 bytes, and Templates of 0 bytes. For now I just copied them out of an existing !NetSurf.
(0000904)
Sprow   
2015-08-13 18:57   
Here's a patch which fixes this issue. I've tested it in all 10 colour depths on RISC OS 5.22, and all 8 colour depths on RISC OS 4.02 (to check I've not broken them!).
(0000905)
Michael Drake   
2015-08-13 20:39   
Could you take a look at this Steve?
(0001008)
Michael Drake   
2015-10-31 19:04   
Applied your patch Sprow, thanks!
(0001278)
Vincent Sanders   
2016-02-16 14:45   
Confirmed fixed in 3.4 release

Issue History
2015-07-29 22:32SprowNew Issue
2015-07-29 22:36SprowNote Added: 0000882
2015-08-11 11:26Rob KendrickNote Added: 0000884
2015-08-12 00:15SprowNote Added: 0000889
2015-08-13 18:56SprowFile Added: buffer.patch
2015-08-13 18:57SprowNote Added: 0000904
2015-08-13 20:39Michael DrakeNote Added: 0000905
2015-08-13 20:39Michael DrakeAssigned To => Steve Fryatt
2015-08-13 20:39Michael DrakeStatusnew => acknowledged
2015-08-13 20:39Michael DrakeSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1524#r1524
2015-10-31 19:04Michael DrakeFixed in CI build # => 3033
2015-10-31 19:04Michael DrakeNote Added: 0001008
2015-10-31 19:04Michael DrakeSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1583#r1583
2015-10-31 19:04Michael DrakeAssigned ToSteve Fryatt => Michael Drake
2015-10-31 19:04Michael DrakeStatusacknowledged => resolved
2015-10-31 19:04Michael DrakeResolutionopen => fixed
2016-02-16 14:45Vincent SandersNote Added: 0001278
2016-02-16 14:45Vincent SandersStatusresolved => closed
2016-02-16 14:45Vincent SandersFixed in Version => 3.4