MantisBT - NetSurf
View Issue Details
0002264NetSurf[All Projects] Generalpublic2015-01-31 14:112015-03-10 23:40
ReporterChris Young 
Assigned ToMichael Drake 
PlatformAmigaOSAmigaOSOS Version4.1
Product Version3.3 
Target Version3.3Fixed in Version3.3 
Fixed in CI build #2590
Reported in CI build #2576
URL of problem page
Summary0002264: Hotlist not saving
DescriptionWhen updating the hotlist, on exit it creates the Hotlist-bk file, but this never gets moved back to Hotlist.

The log suggests the existing Hotlist isn't being deleted (maybe it is locked/in use?)
Steps To ReproduceLoad NetSurf, update hotlist, quit.
Additional Information(27.377755) desktop/hotlist.c hotlist_fini 1277: Finalising hotlist
(27.390008) desktop/hotlist.c hotlist_save 942: Error renaming hotlist: File exists.
(27.390088) desktop/hotlist.c hotlist_fini 1282: Problem saving the hotlist.
(27.391575) desktop/hotlist.c hotlist_fini 1294: Finalised hotlist
TagsNo tags attached.
Attached Files

Michael Drake   
2015-02-03 10:35   
This was caused by the non-POSIX behaviour of rename() on AmigaOS. If you're supposed to be using a POSIX library on AmigaOS, you should file a bug against it.

We now call remove() first, but there is still a race condition on for non-POSIX systems; if a hotlist file is created between remove() and rename(), then rename() will still fail.
Vincent Sanders   
2015-03-10 23:40   
Confirmed fixed in 3.3 release

Issue History
2015-01-31 14:11Chris YoungNew Issue
2015-01-31 14:11Chris YoungStatusnew => assigned
2015-01-31 14:11Chris YoungAssigned To => Michael Drake
2015-02-03 10:35Michael DrakeFixed in CI build # => 2590
2015-02-03 10:35Michael DrakeNote Added: 0000598
2015-02-03 10:35Michael DrakeStatusassigned => resolved
2015-02-03 10:35Michael DrakeResolutionopen => fixed
2015-02-03 10:35Michael DrakeFixed in Version => 3.3
2015-02-03 10:35Michael DrakeDescription Updatedbug_revision_view_page.php?rev_id=1414#r1414
2015-02-03 10:35Michael DrakeAdditional Information Updatedbug_revision_view_page.php?rev_id=1416#r1416
2015-03-10 23:40Vincent SandersNote Added: 0000739
2015-03-10 23:40Vincent SandersStatusresolved => closed