MantisBT - NetSurf
View Issue Details
0002254NetSurfAmiga-specificpublic2015-01-14 18:432015-03-10 23:42
ReporterChris Young 
Assigned ToChris Young 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformAmigaOSAmigaOSOS Version4.1FE
Product Version3.3 
Target Version3.3Fixed in Version3.3 
Fixed in CI build #2526
Reported in CI build #2522
URL of problem page
Summary0002254: Tab close crash in FE
DescriptionClosing a tab when running NetSurf under OS4.1FE can cause a crash in specific circumstances.
Steps To ReproduceFrom the hompage, middle-click a link to open it in a background tab.
Close the original tab.
Middle-click a link from the remaining tab to open another new tab.
Close this newly-opened tab.
Behold, crash.
Additional InformationThis appears to be related to a change in clicktab.gadget, where when tabs are closed it switches back to a different tab than it would previously (appears to always be the first tab). In this instance it may be switching to the tab we have already closed.
I think this is a bug in clicktab.gadget but may be able to work around it.
TagsNo tags attached.
Attached Filestxt Crashlog_NetSurf_2015-01-14_18-31-59.txt (24,493) 2015-01-14 18:43
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=234&type=bug

Notes
(0000570)
Chris Young   
2015-01-16 00:00   
Something buggy regarding clicktab IDs causing this. Might well be that CLICKTAB_AutoNumber has managed to get permanently set, and as we were relying on our clicktab ID staying static they stopped matching up. Have changed to use the node addresses instead, which has actually simplified the code.
(0000750)
Vincent Sanders   
2015-03-10 23:42   
Confirmed fixed in 3.3 release

Issue History
2015-01-14 18:43Chris YoungNew Issue
2015-01-14 18:43Chris YoungStatusnew => assigned
2015-01-14 18:43Chris YoungAssigned To => Chris Young
2015-01-14 18:43Chris YoungFile Added: Crashlog_NetSurf_2015-01-14_18-31-59.txt
2015-01-16 00:00Chris YoungFixed in CI build # => 2526
2015-01-16 00:00Chris YoungNote Added: 0000570
2015-01-16 00:00Chris YoungStatusassigned => resolved
2015-01-16 00:00Chris YoungFixed in Version => 3.3
2015-01-16 00:00Chris YoungResolutionopen => fixed
2015-03-10 23:42Vincent SandersNote Added: 0000750
2015-03-10 23:42Vincent SandersStatusresolved => closed