MantisBT - NetSurf
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002245NetSurf[All Projects] Generalpublic2014-12-16 10:562016-02-16 14:12
ReporterRik Griffin 
Assigned To 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformIyonixOSRISC OSOS Version5.20
Product Version3.2 
Target Version3.4Fixed in Version3.4 
Fixed in CI build #3254
Reported in CI build #2441
URL of problem pagehttp://www.theregister.co.uk/2014/12/15/us_senator_to_congress_close_all_the_backdoors/
Summary0002245: Crash on The Register
DescriptionVisiting this page: http://www.theregister.co.uk/2014/12/15/us_senator_to_congress_close_all_the_backdoors/

causes Netsurt to exit. Log attached.
Steps To ReproduceVisit the above URL.
TagsNo tags attached.
Relationships
has duplicate 0002212closed Michael Drake Crash on BBC News site. 
Attached Files? Log (175,263) 2014-12-16 10:56
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=227&type=bug

Notes
(0001147)
Dave Higton   
2016-01-07 22:31   
I reproduced this with RO build 3252, RO 5.22, Iyonix.
(0001150)
Vincent Sanders   
2016-01-07 23:04   
nsgtk: content/urldb.c:1158: urldb_match_path: Assertion `path[0] == '/'' failed.

our old friend urldb asploding. not confined to RISC OS, thie assert is reproducible anywhere
(0001151)
Michael Drake   
2016-01-08 10:10   
No it's a nsurl bug. URLdb should be able to assume the path is valid, and if it is not, nsurl is not doing its job.

In this case there's a query string (beginning with '?') in the path component.
(0001152)
Michael Drake   
2016-01-08 10:29   
mailto:user@theregister.co.uk?subject=foo

That URL is parsed incorrectly, and the "?subject=foo" ends up in the path component. Also, we should probably limit the :visited handling so it doesn't try to look up mailto: schemes.
(0001154)
Michael Drake   
2016-01-08 15:05   
When we test whether a URL exists in the DB for :visted support we use a bloom filter to speed up the case where its not there. If there is a hash collision then we actually have to do the test fully and hit this assert.
(0001155)
Michael Drake   
2016-01-08 17:22   
Adding an early exit for mailto urls when performing URLdb lookups sidesteps this nsurl parsing bug. URLdb doesn't sore mailto urls, so this is valid.
(0001246)
Vincent Sanders   
2016-02-16 14:12   
Confirmed fixed in 3.4 release

Issue History
Date ModifiedUsernameFieldChange
2014-12-16 10:56Rik GriffinNew Issue
2014-12-16 10:56Rik GriffinFile Added: Log
2014-12-18 20:34Vincent SandersStatusnew => acknowledged
2014-12-18 20:34Vincent SandersDescription Updatedbug_revision_view_page.php?rev_id=1377#r1377
2016-01-07 22:31Dave HigtonNote Added: 0001147
2016-01-07 23:04Vincent SandersNote Added: 0001150
2016-01-07 23:04Vincent SandersStatusacknowledged => confirmed
2016-01-08 10:10Michael DrakeNote Added: 0001151
2016-01-08 10:29Michael DrakeNote Added: 0001152
2016-01-08 10:29Michael DrakeNote Edited: 0001152bug_revision_view_page.php?bugnote_id=1152#r1739
2016-01-08 15:04Michael DrakeRelationship addedhas duplicate 0002212
2016-01-08 15:05Michael DrakeNote Added: 0001154
2016-01-08 17:22Michael DrakeFixed in CI build # => 3254
2016-01-08 17:22Michael DrakeNote Added: 0001155
2016-01-08 17:22Michael DrakeStatusconfirmed => resolved
2016-01-08 17:22Michael DrakeResolutionopen => fixed
2016-01-08 17:22Michael DrakeFixed in Version => 3.4
2016-01-08 17:22Michael DrakeTarget Version => 3.4
2016-02-16 14:12Vincent SandersNote Added: 0001246
2016-02-16 14:12Vincent SandersStatusresolved => closed