MantisBT - NetSurf
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002168NetSurf[All Projects] Generalpublic2014-07-06 23:332015-03-10 11:12
ReporterChris Young 
Assigned ToVincent Sanders 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformAmigaOSAmigaOSOS Version4.1
Product Version3.2 
Target VersionFixed in Version3.2 
Fixed in CI build #2019
Reported in CI build #2000
URL of problem pagehttps://www.unsatisfactorysoftware.co.uk
Summary0002168: Certificate validation tree is corrupted when manipulated
DescriptionThe certificate validation display starts fine (pic 1), and gradually gets worse when the items are expanded (pic 2) and scrolled/redrawn (pic 3)
Steps To ReproduceVisit a site needing certificate verification (I used https://www.unsatisfactorysoftware.co.uk as I know the certificates there are dodgy)
Manipulate the certificate tree by expanding/contracting items and scrolling.
TagsNo tags attached.
Relationships
has duplicate 0002179closed Vincent Sanders Crashes on invalid certificate 
Attached Filesjpg ssl1.jpg (51,473) 2014-07-06 23:33
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=169&type=bug
jpg

jpg ssl2.jpg (48,772) 2014-07-06 23:34
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=170&type=bug
jpg

jpg ssl3.jpg (42,100) 2014-07-06 23:34
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=171&type=bug
jpg

Notes
(0000408)
Vincent Sanders   
2014-07-17 15:34   
I think ci build 2019 should fix this.

This commit addresses the cert_verify() callback constructing treeviews directly from the cert data in the message without copying in it.

 message data is only valid for the duration of its delivery so the certificate information (stored on stack) was simply no longer valid and as the stack was reused became corrupted!

Can you verify on your frontend and close bug if it is rectified
(0000412)
Chris Young   
2014-07-17 23:27   
Confirmed fixed.
(0000720)
Vincent Sanders   
2015-03-10 11:12   
Confirmed fixed in 3.2 release

Issue History
Date ModifiedUsernameFieldChange
2014-07-06 23:33Chris YoungNew Issue
2014-07-06 23:33Chris YoungFile Added: ssl1.jpg
2014-07-06 23:34Chris YoungFile Added: ssl2.jpg
2014-07-06 23:34Chris YoungFile Added: ssl3.jpg
2014-07-07 07:55Vincent SandersStatusnew => acknowledged
2014-07-07 07:55Vincent SandersDescription Updatedbug_revision_view_page.php?rev_id=1291#r1291
2014-07-07 07:55Vincent SandersSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1293#r1293
2014-07-17 15:34Vincent SandersNote Added: 0000408
2014-07-17 15:34Vincent SandersAssigned To => Vincent Sanders
2014-07-17 15:34Vincent SandersStatusacknowledged => confirmed
2014-07-17 18:55Vincent SandersStatusconfirmed => feedback
2014-07-17 23:27Chris YoungFixed in CI build # => 2019
2014-07-17 23:27Chris YoungNote Added: 0000412
2014-07-17 23:27Chris YoungStatusfeedback => assigned
2014-07-17 23:27Chris YoungStatusassigned => resolved
2014-07-17 23:27Chris YoungFixed in Version => 3.2
2014-07-17 23:27Chris YoungResolutionopen => fixed
2014-08-03 14:09Daniel SilverstoneRelationship addedhas duplicate 0002179
2015-03-10 11:12Vincent SandersNote Added: 0000720
2015-03-10 11:12Vincent SandersStatusresolved => closed