MantisBT - NetSurf
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002162NetSurfABENDpublic2014-07-01 21:372015-03-10 11:10
ReporterChris Young 
Assigned ToVincent Sanders 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformAmigaOSAmigaOSOS Version4.1
Product Version3.2 
Target VersionFixed in Version3.2 
Fixed in CI build #1989
Reported in CI build #1986
URL of problem page
Summary0002162: Assert when closing NetSurf before homepage loads
DescriptionHaving a few Internet problems today, so ended up closing NetSurf before it had completed a DNS lookup for my homepage (Google). It ended in an assert which is in the attached log.
I've done this before without error so I think this has been introduced with the scheduled fetches.
Additional InformationIf I wait until the DNS timeout error I can close NetSurf without it asserting.

btw, everything else is working :)
TagsNo tags attached.
Relationships
Attached Fileslog ns.log (1,330,138) 2014-07-01 21:37
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=166&type=bug

Notes
(0000399)
Vincent Sanders   
2014-07-02 14:00   
This was caused because I erroneously believed that all fetches would be aborted during quit and that the refcount on the fetcher should be its initial value.

It appears that aborts on curl handles while resolving are asynchronous and do not complete until "later" the old code logged this outcome and forced the reference count, allowing the fetcher to be stopped anyhow.

I have re instigated the old behaviour with a comment explaining why its necessary.
(0000709)
Vincent Sanders   
2015-03-10 11:10   
Confirmed fixed in 3.2 release

Issue History
Date ModifiedUsernameFieldChange
2014-07-01 21:37Chris YoungNew Issue
2014-07-01 21:37Chris YoungStatusnew => assigned
2014-07-01 21:37Chris YoungAssigned To => Vincent Sanders
2014-07-01 21:37Chris YoungFile Added: ns.log
2014-07-02 14:00Vincent SandersFixed in CI build # => 1989
2014-07-02 14:00Vincent SandersNote Added: 0000399
2014-07-02 14:00Vincent SandersStatusassigned => resolved
2014-07-02 14:00Vincent SandersResolutionopen => fixed
2014-07-02 14:00Vincent SandersFixed in Version => 3.2
2014-07-02 14:00Vincent SandersDescription Updatedbug_revision_view_page.php?rev_id=1279#r1279
2014-07-02 14:00Vincent SandersAdditional Information Updatedbug_revision_view_page.php?rev_id=1281#r1281
2015-03-10 11:10Vincent SandersNote Added: 0000709
2015-03-10 11:10Vincent SandersStatusresolved => closed