MantisBT - NetSurf
View Issue Details
0002159NetSurfGTK-specificpublic2014-06-26 14:302015-03-10 11:12
Reporterjohndory 
Assigned ToVincent Sanders 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformLinuxOSArch linuxOS VersionLinux 3.15.1-1-Arch #1 SMP PREEM
Product Version3.2 
Target VersionFixed in Version3.2 
Fixed in CI build #
Reported in CI build #
URL of problem page
Summary0002159: nsgtk crashes on selecting view source on the default page
DescriptionThe browser_window_create lines in browser.c:
if (!(flags & BW_CREATE_HISTORY)) {
    if (!(flags & BW_CREATE_CLONE) || existing == NULL) {
will always assert because there is no BW_CREATE_HISTORY, or BW_CREATE_CLONE flag in the gtk/dialogs/source.c:
Steps To Reproduce1) Created user, git downloaded ns and libs.
2) Installed to cusom location. PREFIX=/home/user/local
3) Setup PKG_CONFIG_PATH=/home/user/local/lib/pkgconfig & PATH=/home/user/local/bin
4) Compile libs, compile nsgtk
5) Setup NETSURFRES=/home/user/local/share/netsurf
6) cd to home dir, run netsurf, click 'view', choose 'view source', boom.
 
Additional Informationcreated a simple patch and works, however I'm not confident on whether the issue is address properly.
TagsNo tags attached.
Attached Filesdiff report_0001.diff (611) 2014-06-26 14:30
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=165&type=bug

Notes
(0000403)
Vincent Sanders   
2014-07-08 14:22   
I am completely unable to reproduce this either from the about:welcome default or about:blank

can you run netsurf with -v and attach the resulting log to this bug please?
(0000417)
Vincent Sanders   
2014-07-19 11:54   
OK to reproduce this needs to be the blank window not the welcome page
(0000717)
Vincent Sanders   
2015-03-10 11:12   
Confirmed fixed in 3.2 release

Issue History
2014-06-26 14:30johndoryNew Issue
2014-06-26 14:30johndoryFile Added: report_0001.diff
2014-06-26 15:13Vincent SandersAssigned To => Vincent Sanders
2014-06-26 15:13Vincent SandersStatusnew => acknowledged
2014-06-26 15:13Vincent SandersProduct Version => 3.2
2014-06-26 15:13Vincent SandersDescription Updatedbug_revision_view_page.php?rev_id=1271#r1271
2014-06-26 15:13Vincent SandersSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1273#r1273
2014-07-08 14:22Vincent SandersNote Added: 0000403
2014-07-08 14:22Vincent SandersReproducibilityalways => unable to reproduce
2014-07-08 14:22Vincent SandersStatusacknowledged => feedback
2014-07-19 11:54Vincent SandersNote Added: 0000417
2014-07-19 11:54Vincent SandersReproducibilityunable to reproduce => always
2014-07-19 11:54Vincent SandersStatusfeedback => confirmed
2014-07-21 01:20Vincent SandersStatusconfirmed => resolved
2014-07-21 01:20Vincent SandersResolutionopen => fixed
2014-07-21 01:20Vincent SandersFixed in Version => 3.2
2015-03-10 11:12Vincent SandersNote Added: 0000717
2015-03-10 11:12Vincent SandersStatusresolved => closed