MantisBT - NetSurf
View Issue Details
0002131NetSurfAmiga-specificpublic2014-05-23 07:182015-03-10 11:03
Reporterfreddy omholt 
Assigned ToChris Young 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformAmigaNGOSOS4OS Version4.1.6
Product Version3.1 
Target Version3.2Fixed in Version3.2 
Fixed in CI build #1906
Reported in CI build #
URL of problem page
Summary0002131: hotlist management
DescriptionCrash in hotlist management
Steps To Reproducewhen download the latest, rin it sys:internet\Netsurf. everything is fast and smooth. first load up of netsurt went ok, checked fonts, end the startup.

so now it work. in default mode.

i do now a system reboot. just for retest.

start up netsurf, i visit www.Amigans.net, loaded great.

so then, i press the bookmark "Star" on the top left to have saved the site, the i look up hotlist windows, there you have tree chooses.

i just playing around, and tried to drag the hotlist bar to the browser, (trying to make a bookmark toolbar) then it crashes, i i have tried it 3-4 times, everything goes perfekt until i try my nasty drag.

i wasen't sure if netsuft had an bookmark add-on bar in man gui, so it just tred
Additional Informationthis i is my first bug report for any software, so go easy on me:)
TagsNo tags attached.
Attached Filestxt Crashlog_NetSurf_2014-05-22_21-26-39.txt (25,489) 2014-05-23 07:18
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=148&type=bug

Notes
(0000347)
Chris Young   
2014-05-23 11:01   
Freddy,

NetSurf does have a bookmark toolbar, in the hotlist window you just need to drag the entries into the "Hotlist toolbar" folder. The toolbar will appear when the hotlist window is closed (it auto-hides when there are no entries).

I will look into the crash. You should be able to drag entries into the browser window to open them in that window/tab. I always drag to the left, it may be that dragging upwards is the problem.

Chris
(0000348)
Chris Young   
2014-05-23 17:52   
I can reproduce a similar crash by dragging a folder rather than a hotlist entry into the browser window.
Any items dragged up or down are moved in the hotlist irrespective of whether they were dropped inside or outside the hotlist window, so that needs fixing too.
(0000349)
Chris Young   
2014-05-24 11:57   
I've fixed the entries moving even though they've been dragged outside the window, in CI build 1903.

Michael - the crashing appears to be caused by hotlist_get_selection casting folders to a hotlist_entry and thus causing garbage to be returned for the nsurl. The same bug occurs in global_history too.
(0000350)
Michael Drake   
2014-05-24 15:26   
Chris: thanks should be fixed now.

If the original issue is fixed please close the bug.

(Amiga's the only front end using that API, so I can't test it myself.)
(0000700)
Vincent Sanders   
2015-03-10 11:03   
Confirmed fixed in 3.2 release

Issue History
2014-05-23 07:18freddy omholtNew Issue
2014-05-23 07:18freddy omholtFile Added: Crashlog_NetSurf_2014-05-22_21-26-39.txt
2014-05-23 11:01Chris YoungNote Added: 0000347
2014-05-23 11:01Chris YoungAssigned To => Chris Young
2014-05-23 11:01Chris YoungStatusnew => assigned
2014-05-23 14:42Chris YoungStatusassigned => acknowledged
2014-05-23 14:44Chris YoungTarget Version => 3.2
2014-05-23 17:52Chris YoungNote Added: 0000348
2014-05-23 17:52Chris YoungStatusacknowledged => confirmed
2014-05-23 17:52Chris YoungSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1226#r1226
2014-05-24 11:57Chris YoungNote Added: 0000349
2014-05-24 11:57Chris YoungAssigned ToChris Young => Michael Drake
2014-05-24 11:57Chris YoungStatusconfirmed => assigned
2014-05-24 15:26Michael DrakeNote Added: 0000350
2014-05-24 15:26Michael DrakeAssigned ToMichael Drake => Chris Young
2014-05-24 15:26Michael DrakeSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1227#r1227
2014-05-24 16:58Chris YoungFixed in CI build # => 1906
2014-05-24 16:58Chris YoungStatusassigned => resolved
2014-05-24 16:58Chris YoungFixed in Version => 3.2
2014-05-24 16:58Chris YoungResolutionopen => fixed
2015-03-10 11:03Vincent SandersNote Added: 0000700
2015-03-10 11:03Vincent SandersStatusresolved => closed