MantisBT - NetSurf
View Issue Details
0002103NetSurfLayoutpublic2014-04-09 15:152015-03-10 11:02
ReporterVincent Sanders 
Assigned ToMichael Drake 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.1 
Target Version3.1Fixed in Version3.1 
Fixed in CI build #
Reported in CI build #1789
URL of problem page
Summary0002103: Table layout is not correctly confining rowspans to their groups
DescriptionA table with a rowspan entry affects subsequent rows outside its grouping (eg. thead block) causing incorrect layout.
TagsNo tags attached.
related to 0002102closed Michael Drake click on URL causes crash - Assertion failed 
Attached Fileshtml rowspntst.html (497) 2014-04-09 18:13
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=118&type=bug
png goodtble.png (33,123) 2014-04-09 18:15
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=119&type=bug
png

png badtble.png (43,120) 2014-04-09 18:18
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=120&type=bug
png

Notes
(0000299)
Vincent Sanders   
2014-04-09 18:22   
Improved in commit cfc75ac6f98ce614cb224ffa243daf68a166c907 but need to collapse spurious columns
(0000301)
Michael Drake   
2014-04-09 22:17   
22:05 < tlsa> i think there's a fairly neat way to fix it
22:06 < tlsa> make box_normalise_table_spans() operate on a row_group, rather
              than a whole table
22:07 < tlsa> and call it at the end of row_group normalisation, rather than
              the end of table normalisation

The columns list would also need to be adapted for the change to covering just a single row group.
(0000302)
Michael Drake   
2014-04-09 22:20   
When this is fixed, c36078db73ba4a5e7ad5fa0019dfa3fffdead59d can be reverted.
(0000303)
Michael Drake   
2014-04-12 16:19   
Fixed in 679c87e527e03926b6369c0f82096e5459beef13.
(0000695)
Vincent Sanders   
2015-03-10 11:02   
Confirmed fixed in 3.1 release

Issue History
2014-04-09 15:15Vincent SandersNew Issue
2014-04-09 15:15Vincent SandersFile Added: crash2.html
2014-04-09 15:15Vincent SandersRelationship addedrelated to 0002102
2014-04-09 15:16Vincent SandersStatusnew => confirmed
2014-04-09 15:19Vincent SandersFile Added: goodtble.png
2014-04-09 18:13Vincent SandersFile Deleted: crash2.html
2014-04-09 18:13Vincent SandersFile Deleted: goodtble.png
2014-04-09 18:13Vincent SandersFile Added: rowspntst.html
2014-04-09 18:15Vincent SandersFile Added: goodtble.png
2014-04-09 18:18Vincent SandersFile Added: badtble.png
2014-04-09 18:22Vincent SandersNote Added: 0000299
2014-04-09 22:14Vincent SandersAssigned To => Vincent Sanders
2014-04-09 22:17Michael DrakeNote Added: 0000301
2014-04-09 22:20Michael DrakeNote Added: 0000302
2014-04-12 16:19Michael DrakeNote Added: 0000303
2014-04-12 16:19Michael DrakeAssigned ToVincent Sanders => Michael Drake
2014-04-12 16:19Michael DrakeStatusconfirmed => resolved
2014-04-12 16:19Michael DrakeResolutionopen => fixed
2014-04-12 16:19Michael DrakeFixed in Version => 3.1
2014-04-12 16:19Michael DrakeTarget Version => 3.1
2015-03-10 11:02Vincent SandersNote Added: 0000695
2015-03-10 11:02Vincent SandersStatusresolved => closed