MantisBT - NetSurf
View Issue Details
0002095NetSurf[All Projects] Generalpublic2014-03-15 14:302015-03-10 11:00
ReporterMd. Al-Amin 
Assigned ToVincent Sanders 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformLinuxOSLinux MintOS Version15
Product Version3.0 
Target Version3.1Fixed in Version3.1 
Fixed in CI build #1763
Reported in CI build #
URL of problem pagehttps://www.google.com
Summary0002095: 'Segmentation fault' on opening new tab.
DescriptionOpening url in a new tab from google search result gives unexpected abort.
Steps To ReproduceType https://www.google.com on your browser url, hit enter. then search for "twitter". Try to open the firt link on new tab ( using option 'Open link in New tab") . Click on the newly opened tab.
Additional InformationI also run "./nsgtk -v ". here is the log this run.

http://paste.ubuntu.com/7095738/
TagsNo tags attached.
Attached Files

Notes
(0000275)
Michael Drake   
2014-03-16 19:49   
This happens if you switch tab before the new tab has finished loading.
(0000276)
Achal   
2014-03-16 21:28   
I found out that if we remove L2440 and L2441 of netsurf/gtk/scaffolding.c then this bug get fixed.

https://github.com/Achal-Aggarwal/netsurf/blob/master/gtk/scaffolding.c#L2440

I don't know what is the purpose of those lines.

Actually when a tab is in loading state and user click on it to focus on it, then method "nsgtk_scaffolding_set_top_level" is called to set the current active top level gui window. The browser window associated with it doesn't have scaffold and in the method "nsgtk_search_set_forward_state" a null pointer is accessed which in result do "Seg fault".
(0000281)
Vincent Sanders   
2014-03-18 16:06   
This might be fixed with git commit a67c49eacfcdfc65aadd457df9c63232eb806624 can you retest and confirm
(0000282)
Achal   
2014-03-18 16:18   
@test
before patch : successfully reproduced the issue
after patch : no issue.

Patch fix this issue.
(0000283)
Md. Al-Amin   
2014-03-18 17:14   
Yeah, tested that, no issue there now.
(0000688)
Vincent Sanders   
2015-03-10 11:00   
Confirmed fixed in 3.1 release

Issue History
2014-03-15 14:30Md. Al-AminNew Issue
2014-03-16 17:51Vincent SandersStatusnew => acknowledged
2014-03-16 19:49Michael DrakeNote Added: 0000275
2014-03-16 19:49Michael DrakeStatusacknowledged => confirmed
2014-03-16 21:28AchalNote Added: 0000276
2014-03-17 16:11Vincent SandersTarget Version => 3.1
2014-03-18 16:06Vincent SandersNote Added: 0000281
2014-03-18 16:06Vincent SandersStatusconfirmed => feedback
2014-03-18 16:18AchalNote Added: 0000282
2014-03-18 17:14Md. Al-AminNote Added: 0000283
2014-03-18 17:14Md. Al-AminStatusfeedback => new
2014-03-18 19:23Vincent SandersFixed in CI build # => 1763
2014-03-18 19:23Vincent SandersAssigned To => Vincent Sanders
2014-03-18 19:23Vincent SandersStatusnew => resolved
2014-03-18 19:23Vincent SandersResolutionopen => fixed
2014-03-18 19:23Vincent SandersFixed in Version => 3.1
2015-03-10 11:00Vincent SandersNote Added: 0000688
2015-03-10 11:00Vincent SandersStatusresolved => closed