MantisBT - NetSurf
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001884NetSurf[All Projects] Generalpublic2012-08-18 15:272016-11-22 21:59
ReporterJames Le Cuirot 
Assigned To 
PrioritynormalSeverityfeatureReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version3.6 
Fixed in CI build #
Reported in CI build #
URL of problem page
Summary0001884: Conditionally include image headers
DescriptionHere's a patch that conditionally include image headers to allow building without some dependencies present, such as libnsbmp. Without this, it complains that libnsbmp.h is missing.
Additional InformationImported from sourceforge bug http://sourceforge.net/support/tracker.php?aid=3559268 on Tue Dec 10 17:34:13 2013

TagsNo tags attached.
Relationships
Attached Filespatch netsurf-2.9-conditionally-include-image-headers.patch (1,182) 2013-12-20 12:15
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=34&type=bug

Notes
(0000093)
Vincent Sanders   
2013-12-20 11:49   
NetSurf build system needs to make the image libs optional is what this was asking. We dropped the patch on the floor in the sourceforge move though.
(0000094)
James Le Cuirot   
2013-12-20 12:15   
(Last edited: 2013-12-20 12:16)
Here is the patch. It still appears to be necessary. Makefile.config allows you to disable certain image formats but this doesn't work in practise without this patch. For example, if you disable BMP support, image/bmp.h will include libnsbmp.h anyway when it might not be present. Here is a failed build log from Gentoo Linux.

https://tinderboxlogs.s3.amazonaws.com/tbamd64.excelsior.flameeyes.eu/www-client%3Anetsurf-2.9%3A20120730-113505.html

Note that I haven't tested against the latest version as I don't use NetSurf any more.
(0001389)
Vincent Sanders   
2016-08-14 23:05   
NETSURF_USE_BMP := NO
in Makefile.config now works as does disabling any of teh supported image handlers
(0001429)
Vincent Sanders   
2016-11-22 21:59   
this issue has been closed because it is included in the 3.6 release

Issue History
Date ModifiedUsernameFieldChange
2013-12-10 17:41Vincent SandersNew Issue
2013-12-10 17:41Vincent SandersStatusnew => assigned
2013-12-10 17:41Vincent SandersAssigned To => Sourceforge Import placeholder
2013-12-20 11:49Vincent SandersNote Added: 0000093
2013-12-20 11:49Vincent SandersAssigned ToSourceforge Import placeholder =>
2013-12-20 11:49Vincent SandersSeverityminor => feature
2013-12-20 11:49Vincent SandersStatusassigned => acknowledged
2013-12-20 11:49Vincent SandersResolutionno change required => open
2013-12-20 11:49Vincent SandersAdditional Information Updatedbug_revision_view_page.php?rev_id=559#r559
2013-12-20 12:15James Le CuirotNote Added: 0000094
2013-12-20 12:15James Le CuirotFile Added: netsurf-2.9-conditionally-include-image-headers.patch
2013-12-20 12:16James Le CuirotNote Edited: 0000094bug_revision_view_page.php?bugnote_id=94#r573
2016-08-14 23:05Vincent SandersNote Added: 0001389
2016-08-14 23:05Vincent SandersStatusacknowledged => resolved
2016-08-14 23:05Vincent SandersResolutionopen => fixed
2016-08-14 23:05Vincent SandersFixed in Version => 3.6
2016-11-22 21:59Vincent SandersNote Added: 0001429
2016-11-22 21:59Vincent SandersStatusresolved => closed