MantisBT - NetSurf
View Issue Details
0002483NetSurfDevelopmentpublic2016-11-21 02:532017-10-16 22:42
Reporternpnth 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionopen 
Platformx86_64OSGentoo LinuxOS VersionRolling
Product Version3.6 
Target VersionFixed in Version3.7 
Fixed in CI build #
Reported in CI build #
URL of problem page
Summary0002483: Build failure since e8a9e3744523671228fef385ce7e1e11f93283b0 with LibreSSL
DescriptionLibreSSL sets OPENSSL_VERSION_NUMBER to 0x20000000L, but does not necessarily follow OpenSSL's feature changes. As a result, commit e8a9e3744523671228fef385ce7e1e11f93283b0 thinks builds with LibreSSL should use OpenSSL 1.1.0-style X509 certificate handling, which LibreSSL doesn't provide.
Steps To ReproduceUse LibreSSL (version 2.5.0 has been observed with this issue), attempt to build.
Additional InformationLibreSSL defines LIBRESSL_VERSION_NUMBER. Perhaps the check could be changed to

    #if (OPENSSL_VERSION_NUMBER < 0x1010000fL) || defined(LIBRESSL_VERSION_NUMBER)

? I have checked this locally, and it seems to work.
TagsNo tags attached.
Attached Files

Notes
(0001420)
Vincent Sanders   
2016-11-21 22:46   
Thanks for the bug report and analysis, I have independently found the issue and resolved it. do let me know if this does not fix it for you though.

http://source.netsurf-browser.org/netsurf.git/commit/?id=3f88c12315556d6f5f928c7e6a5e56357899ece7
(0001676)
Vincent Sanders   
2017-10-16 22:42   
Thankyou for your report, this has been resolved in the 3.7 release

Issue History
2016-11-21 02:53npnthNew Issue
2016-11-21 22:46Vincent SandersNote Added: 0001420
2016-11-21 22:46Vincent SandersStatusnew => resolved
2016-11-21 22:46Vincent SandersFixed in Version => 3.7
2017-10-16 22:42Vincent SandersStatusresolved => closed
2017-10-16 22:42Vincent SandersNote Added: 0001676